Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete validation requires a global variable #716

Open
adamliptrot-oc opened this issue Nov 24, 2016 · 2 comments
Open

AutoComplete validation requires a global variable #716

adamliptrot-oc opened this issue Nov 24, 2016 · 2 comments

Comments

@adamliptrot-oc
Copy link
Contributor

When instantiating an autoComplete instance, you currently need to supply a global js object containing all the data for the suggestions to the validator. This is currently done via a data-suggestions attribute on the autocomplete html.

We should look at alternative approaches to pass this data back to the validator.

@feedmypixel
Copy link
Contributor

As discussed the need to have this on the host window object can go and this can just be sent in as an object via the data-suggestions attribute

@rpowis
Copy link
Contributor

rpowis commented Dec 2, 2016

@adamliptrot-oc Does the above PR (#709) close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants