Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple important warning styles #657

Open
feedmypixel opened this issue Jun 29, 2016 · 3 comments
Open

Multiple important warning styles #657

feedmypixel opened this issue Jun 29, 2016 · 3 comments

Comments

@feedmypixel
Copy link
Contributor

Duplicate important messages

We have multiple ways of displaying error warnings. They could do with discussion on the relevant hackpad pages and design review from @hmrc/designers then duplicates can be marked as deprecated and removed

.important-notice

component-library
screen shot 2016-06-29 at 10 15 48

.indent-warning

component-library
screen shot 2016-06-29 at 10 21 03

.highlight--*

[component-library](http://hmrc.github.io/assets-frontend/component-library/section-notification.html#kssref-notification-highlight]
notifications

@pietrodesiato
Copy link

Is there an easy way of importing the component library elements into the hackpad for discussion? Happy to use screenshots but just wondering if there's a better and more reliable way.

@rpowis
Copy link
Contributor

rpowis commented Jul 1, 2016

@pietrodesiato Each hackpad has the link back to the component that the discussion should be around.

If it's a case of showing alternatives then screenshots would be the only way as hackpad doesn't render markup.

@gavinwye
Copy link
Contributor

gavinwye commented May 3, 2017

Summarising comments from Slack

View the original messages

Kieran Wyatt
image
Hi all. I’ve started as a content designer for HMRC in Newcastle. Got a quick query I’d value your feedback on…
I’m looking at a prototype for a page on the TaxCalc redesign. On the page will be an alert notice - see attached image.
Our developer needs an alt tag that will be read by screen readers for the black circle with the white exclamation point.
Is there a standard alt tag or descriptor for such a symbol? “Important notice”? “Warning! Warning!” etc

Phil Sherry
@kieran.wyatt This is the component library that is used in the service:
http://hmrc.github.io/assets-frontend/section-icons.html#kssref-icons-exclamation
This is the one probably used in the prototype:
https://govuk-elements.herokuapp.com/icons-images/
govuk-elements.herokuapp.com
Icons and images — GOV.UK elements (15kB)
You’ll notice neither use an

Steven Proctor
There isn't a standard, although there should be.
I've seen icons with alt text that says "Important", "Help" and others.
The version in elements says "Warning" in a visuallyhidden span instead of using an image like @philip.sherry says. The one in assets frontend doesn't have a visuallyhidden span, but the tick icon has an aria label of "tick".
The fact that the icon is there should be announced to a screen reader, otherwise they would not know it was there and it does carry important info.
Because it's only supposed to be used for legal text I'd be tempted to use "Important legal notice" or "Legal notice". (edited)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants