fix: removed unnecessary props

yamada-ui · Jun 9, 2023 · b1581a6 · b1581a6
1 parent 0e6ef97
commit b1581a6
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/.changeset/fresh-islands-visit.md b/.changeset/fresh-islands-visit.md
@@ -0,0 +1,6 @@
+---
+'@yamada-ui/checkbox': patch
+'@yamada-ui/radio': patch
+---
+
+Removed unnecessary props passed to DOM.
diff --git a/packages/components/checkbox/src/checkbox-group.tsx b/packages/components/checkbox/src/checkbox-group.tsx
@@ -129,7 +129,15 @@ export const CheckboxGroup = forwardRef(
           role='group'
           direction={direction}
           gap={gap ?? (direction === 'row' ? '1rem' : undefined)}
-          {...omitObject(props, ['value', 'defaultValue', 'onChange'])}
+          {...omitObject(props, [
+            'value',
+            'defaultValue',
+            'onChange',
+            'isInvalid',
+            'isDisabled',
+            'isRequired',
+            'isReadOnly',
+          ])}
         >
           {children}
         </Flex>

diff --git a/packages/components/radio/src/radio-group.tsx b/packages/components/radio/src/radio-group.tsx
@@ -167,7 +167,9 @@ export const RadioGroup = forwardRef(
           className={cx('ui-radio-group', className)}
           direction={direction}
           gap={gap ?? (direction === 'row' ? '1rem' : undefined)}
-          {...getContainerProps(omitObject(props, ['onChange']))}
+          {...getContainerProps(
+            omitObject(props, ['onChange', 'isInvalid', 'isDisabled', 'isRequired', 'isReadOnly']),
+          )}
         >
           {children}
         </Flex>