refactor(components/select): restructured Select element

yamada-ui · Nov 26, 2023 · a1ee1bd · a1ee1bd
1 parent 965abe7
commit a1ee1bd
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 12 deletions.
diff --git a/.changeset/fuzzy-coats-listen.md b/.changeset/fuzzy-coats-listen.md
@@ -0,0 +1,5 @@
+---
+"@yamada-ui/select": patch
+---
+
+Restructured `Select` inner element.
diff --git a/packages/components/select/src/select.tsx b/packages/components/select/src/select.tsx
@@ -169,21 +169,21 @@ export const Select = forwardRef<SelectProps, "div">((props, ref) => {
               __css={{ position: "relative", ...styles.inner }}
             >
               <PopoverTrigger>
-                <SelectField h={h} minH={minH} {...getFieldProps({}, ref)}>
-                  <SelectIcon {...iconProps} {...formControlProps} />
-                </SelectField>
+                <SelectField h={h} minH={minH} {...getFieldProps({}, ref)} />
               </PopoverTrigger>
 
-              {!isEmpty ? (
-                <SelectList {...listProps}>
-                  {!!placeholder && placeholderInOptions ? (
-                    <Option>{placeholder}</Option>
-                  ) : null}
-
-                  {children ?? computedChildren}
-                </SelectList>
-              ) : null}
+              <SelectIcon {...iconProps} {...formControlProps} />
             </ui.div>
+
+            {!isEmpty ? (
+              <SelectList {...listProps}>
+                {!!placeholder && placeholderInOptions ? (
+                  <Option>{placeholder}</Option>
+                ) : null}
+
+                {children ?? computedChildren}
+              </SelectList>
+            ) : null}
           </ui.div>
         </Popover>
       </SelectProvider>