Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use API for nonce detection if available #1704

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Jun 17, 2024

This PR was published to npm with the version 6.15.0
e.g. npm install @stacks/[email protected] --save-exact

@janniks janniks self-assigned this Jun 17, 2024
Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 0:23am

@janniks janniks requested a review from zone117x June 17, 2024 11:33
@janniks janniks marked this pull request as ready for review June 17, 2024 11:33
@janniks janniks changed the title feat: use API for nonce detection if available feat: Use API for nonce detection if available Jun 17, 2024
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.82%. Comparing base (33ca645) to head (4d82694).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1704      +/-   ##
==========================================
+ Coverage   66.79%   66.82%   +0.03%     
==========================================
  Files         119      119              
  Lines        8838     8845       +7     
  Branches     1963     1955       -8     
==========================================
+ Hits         5903     5911       +8     
+ Misses       2788     2783       -5     
- Partials      147      151       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janniks janniks merged commit 855ca69 into main Jun 17, 2024
11 checks passed
@janniks janniks deleted the nonce-detection branch June 17, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incorrect nonce set while building transaction with makeUnsignedContractCall
2 participants