Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stacking): add getSecondsUntilStackingDeadline helper method #1528

Merged
merged 4 commits into from
Jul 24, 2023
Merged

feat(stacking): add getSecondsUntilStackingDeadline helper method #1528

merged 4 commits into from
Jul 24, 2023

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Jul 5, 2023 •
edited by github-actions bot
Loading

This PR was published to npm with the version 6.5.5-pr.231b5a8.0
e.g. npm install @stacks/[email protected] --save-exact

@friedger does this make more sense? 🙏

@janniks janniks linked an issue Jul 5, 2023 that may be closed by this pull request
getSecondsUntilNextCycle does not use perpare phase #1514
Closed
@vercel
Copy link

vercel bot commented Jul 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 6:03pm

@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Merging #1528 (231b5a8) into main (ee4df48) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
+ Coverage   66.16%   66.19%   +0.02%     
==========================================
  Files         118      118              
  Lines        8631     8638       +7     
  Branches     1906     1885      -21     
==========================================
+ Hits         5711     5718       +7     
- Misses       2683     2793     +110     
+ Partials      237      127     -110
Impacted Files Coverage Δ
packages/stacking/src/index.ts 89.76% <100.00%> (+0.50%) ⬆️

... and 25 files with indirect coverage changes

friedger
friedger approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@friedger friedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added suggestions to improve documentation.

packages/stacking/src/index.ts Show resolved Hide resolved
packages/stacking/tests/stacking.test.ts Show resolved Hide resolved
@janniks janniks force-pushed the 1514-getsecondsuntilnextcycle-does-not-use-perpare-phase branch from f59f2f7 to c6b31e2 Compare July 14, 2023 10:16
@janniks janniks changed the title fix: prefer getSecondsUntilStackingDeadline over getSecondsUntilNextC… feat(stacking): add getSecondsUntilStackingDeadline helper method Jul 24, 2023
@janniks janniks merged commit 3c819c2 into main Jul 24, 2023
@janniks janniks deleted the 1514-getsecondsuntilnextcycle-does-not-use-perpare-phase branch July 24, 2023 18:17
This was referenced Jul 24, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedger friedger friedger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getSecondsUntilNextCycle does not use perpare phase
2 participants
@janniks @friedger