Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on 3.0 Block View #1721

Closed
saralab opened this issue Jul 9, 2024 · 11 comments
Closed

Feedback on 3.0 Block View #1721

saralab opened this issue Jul 9, 2024 · 11 comments
Assignees

Comments

@saralab
Copy link
Contributor

saralab commented Jul 9, 2024

  1. STX Icon + STX Blocks
    At first glance when you see the Blocks View under the 3.0 Testnet, it can be misleading to see only the first STX Block within the BTC Block to have the STX icon next to it. At first I presumed the rest of the blocks in the list were transactions within the STX block #121443.
    Update this view to include STX icon next to all the STX Blocks.
Screenshot 2024-07-08 at 11 42 16 PM
  1. The first BTC block in the list shows the expanded view of the STX blocks and the following BTC blocks are collapsed and show the total STX blocks count. When I click on the BTC block, I expected it to expand in the same screen , instead it takes me to a new screen with the detailed block view.
    Update this to expand/collapse the STX Blocks within the BTC block in the same screen
Screenshot 2024-07-08 at 11 55 03 PM Screenshot 2024-07-08 at 11 48 08 PM
@ginny-d
Copy link

ginny-d commented Jul 9, 2024

Thanks for the feedback, Sarala

Here are a couple of comments from Design:

  1. I recommend against adding an STX icon next to every block. It can look repetitive and redundant:
Blocks -

Instead, I suggest adding the STX icon next to the first and the last Block of the string, and colouring the circles in purple, as a more minimal visual hint:

Blocks-1
  1. Engineering can give more context and confirm why this works this way. My understanding is that the reason is to improve performance.

@BLuEScioN
Copy link
Collaborator

I agree having a STX icon for each dot is a little overwhelming. I would even go as far as to say just making the dots all purple after the first one is enough visual communication to tell that evreything else is a STX block, too.

I'll add my 2 cents about #2.

Yes, we are only populating the first btc block with stx blocks for performance reasons. We are intentionally trying to NOT make additional requests to the API as well as make sure we are not hitting the API request limit.

We can add the click functionality in order for the user to be able to load stx blocks for the btc block, and only load the stx blocks when the user clicks to expand the btc block. However, is there a specific use case where users will be using this page to inspect multiple btc blocks for stx blocks?

@BLuEScioN BLuEScioN self-assigned this Jul 22, 2024
@andresgalante
Copy link
Member

andresgalante commented Jul 24, 2024

Feedback from @saralab :
In the default view, we should at least see the first and last STX blocks within each BTC block; otherwise, the list of BTC blocks provides no valuable information.

@BLuEScioN, if this is feasible, please work with @ginny-d for the design

@ginny-d
Copy link

ginny-d commented Jul 24, 2024

Re:

The first BTC block in the list shows the expanded view of the STX blocks and the following BTC blocks are collapsed and show the total STX blocks count. When I click on the BTC block, I expected it to expand in the same screen , instead it takes me to a new screen with the detailed block view.
Update this to expand/collapse the STX Blocks within the BTC block in the same screen

If we expand the view on the same page we would have hundreds (if not thousands?) of STX blocks on a string showing up, and the scroll would be significantly long. This is why the initial proposal was to open on a new page, which also gives us the ability to generate a specific URL to share/link to a specific set of STX block strings (which would be this page). If we expand the string on blocks on the Blocks page, we'd lose this.

@sarala Is there a strong use case for why we'd need to show the full list of STX blocks of a given BTC blocks on the Blocks page?


If we decide to move forward with this, I'd suggest loading 10 or 20 blocks at a time, and having a button for "load # more blocks". I'll prepare a mock-up once I hear back with more details

@BLuEScioN
Copy link
Collaborator

BLuEScioN commented Jul 24, 2024

@ginny-d
image

One issue I think will come up with the way that we are showing the first and last block is that if we add functionality to load blocks, then it's possible for the block count badge to disappear, and that's the only link the ui to go to the block page. What if just include the range of stx blocks included in the btc block somewhere else so we can avoid this? Perhaps we can make it additional information that is shown once the user hovers over the block count badge? (edited)

@ginny-d
Copy link

ginny-d commented Jul 26, 2024

One issue I think will come up with the way that we are showing the first and last block is that if we add functionality to load blocks, then it's possible for the block count badge to disappear, and that's the only link the ui to go to the block page. What if just include the range of stx blocks included in the btc block somewhere else so we can avoid this? Perhaps we can make it additional information that is shown once the user hovers over the block count badge

I see what you mean. However, I still think that adding a 'load more blocks' feature to this view may not be beneficial, as with Nakamoto we'll have hundreds or thousands of STX blocks. I find it difficult to think of a scenario where users would find value in scrolling through a long list of blocks in this limited view.

Instead, I propose creating a separate page dedicated to displaying the set of STX blocks within a BTC block. We could also make the BTC block number itself a clickable link to this new 'set of STX blocks' page.

@ginny-d
Copy link

ginny-d commented Aug 2, 2024

@andresgalante
Copy link
Member

andresgalante commented Aug 2, 2024

Thank you for all the changes and the discussion here 🙏

@ginny-d I'd like to have the information about the reminding blocks, would it be possible to bring back the "+123 blocks" somewhere, it can even be within or besides the "load more" action?

And, to simplify implementation, it'd be better to make all BTC blocks the same as the first with 10 STX blocks per BTC block

What do you think?

@BLuEScioN
Copy link
Collaborator

BLuEScioN commented Aug 2, 2024

Thanks @ginny-d for the design. Will have this up today.

I do think it's good to keep the "+X blocks" in the pill, too, as well as making all the btc blocks the same

Also, do we really need the button to go to the blocks page? The link is also embedded in the btc block height and hash

@ginny-d
Copy link

ginny-d commented Aug 5, 2024

Thanks @ginny-d for the design. Will have this up today.

I do think it's good to keep the "+X blocks" in the pill, too, as well as making all the btc blocks the same

Also, do we really need the button to go to the blocks page? The link is also embedded in the btc block height and hash

I don't think we absolutely need the link, but as it is, it's not super obvious. We can wait until we see if there's feedback around it or a strong request for it.

Some feedback:

  • On Blocks page, the first "+1 block" is on black, while the others are purple (interactive):
Screenshot 2024-08-05 at 14 35 44 Screenshot 2024-08-05 at 14 35 34
  • There has been a regression with the BTC icon displaying small in the STX block page:
Screenshot 2024-08-05 at 14 36 29

@andresgalante
Copy link
Member

This was shipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants