Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how EC integration gets current page’s locale #1

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Refactor how EC integration gets current page’s locale #1

merged 2 commits into from
Nov 19, 2023

Conversation

delucis
Copy link

@delucis delucis commented Nov 18, 2023

Description

  • This PR refactors how the Starlight Expressive Code integration gets the locale for the current page.
  • We already wrote logic for this as part of Support translating default aside titles withastro/starlight#517 that accounts for things like user configuration of Astro’s srcDir option, so this PR pulls that out into a shared helper and reuses it.

@delucis delucis mentioned this pull request Nov 18, 2023
Merged
hippotastic
hippotastic approved these changes Nov 19, 2023
View reviewed changes
Copy link
Owner

@hippotastic hippotastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!

@hippotastic hippotastic merged commit 6ef1ef7 into hippotastic:add-expressive-code Nov 19, 2023
1 check passed
@hippotastic hippotastic deleted the chris/ec-refactoring branch November 19, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hippotastic hippotastic hippotastic approved these changes

Assignees
No one assigned
Labels
🌟 core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucis @hippotastic