Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The update in DQN #31

Closed
YuxuanXie opened this issue Jun 26, 2020 · 2 comments
Closed

The update in DQN #31

YuxuanXie opened this issue Jun 26, 2020 · 2 comments

Comments

@YuxuanXie
Copy link

Hi,

I get a question about your implementation of DQN, which is supposed to have a C-interval-update between target q-network and current q-network. I see this update in your implementation of DDQN. Can you please tell me why it is this way?

In my point of view, your implementation of ddqn is actually dqn.


Best,
Yuxuan

@douglasrizzo
Copy link

I realized that too. In fact, there is no target network at all in 1.dqn.ipynb.

The following line in the notebook (cell 19):

next_q_values = model(next_state)

Should be:

next_q_values = target_model(next_state)

@YuxuanXie
Copy link
Author

Yes, you are right. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants