Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

margin loss wrong #1

Open
DanlanChen opened this issue Jan 31, 2018 · 2 comments
Open

margin loss wrong #1

DanlanChen opened this issue Jan 31, 2018 · 2 comments

Comments

@DanlanChen
Copy link

Hello, I think your magin loss is wrong, according to the paper, after relu, there is a square you forgot

@DanlanChen
Copy link
Author

I think it should be
left = ((F.relu(0.9 - v_c))**2).view(batch_size, -1)
right = ((F.relu(v_c - 0.1))**2).view(batch_size, -1)

@alexlopezcifuentes
Copy link

I have also noticed that little mistake and reviewing the paper it is clear that there are two missing squares.

Repository owner deleted a comment from devsquadcore Mar 14, 2024
Repository owner deleted a comment from devsquadcore Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants