Skip to content

feat: remove caching from getTransactionCount with block tag = latest #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
Merged

feat: remove caching from getTransactionCount with block tag = latest #4398

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b23a21d
chore: remove cache
natanasow Sep 19, 2025
66d95af
chore: remove cache
natanasow Sep 19, 2025
7b38629
chore: remove unused else
natanasow Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 6 additions & 26 deletions packages/relay/src/lib/services/ethService/accountService/AccountService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// SPDX-License-Identifier: Apache-2.0

import { ConfigService } from '@hashgraph/json-rpc-config-service/dist/services';
import { Logger } from 'pino';

import { numberTo0x, parseNumericEnvVar } from '../../../../formatters';
Expand All @@ -10,7 +9,6 @@ import { JsonRpcError, predefined } from '../../../errors/JsonRpcError';
import { RequestDetails } from '../../../types';
import { LatestBlockNumberTimestamp } from '../../../types/mirrorNode';
import { CacheService } from '../../cacheService/cacheService';
import { CommonService } from '../ethCommonService/CommonService';
import { ICommonService } from '../ethCommonService/ICommonService';
import { IAccountService } from './IAccountService';

Expand Down Expand Up @@ -300,41 +298,23 @@ export class AccountService implements IAccountService {
this.logger.trace(`getTransactionCount(address=${address}, blockNumOrTag=${blockNumOrTag})`);
}

// cache considerations for high load
const cacheKey = `eth_getTransactionCount_${address}_${blockNumOrTag}`;
let nonceCount = await this.cacheService.getAsync(cacheKey, constants.ETH_GET_TRANSACTION_COUNT);
if (nonceCount) {
if (this.logger.isLevelEnabled('trace')) {
this.logger.trace(`returning cached value ${cacheKey}:${JSON.stringify(nonceCount)}`);
}
return nonceCount;
}

const blockNum = Number(blockNumOrTag);
if (blockNum === 0 || blockNum === 1) {
// previewnet and testnet bug have a genesis blockNumber of 1 but non system account were yet to be created
return constants.ZERO_HEX;
} else if (this.common.blockTagIsLatestOrPending(blockNumOrTag)) {
// if latest or pending, get latest ethereumNonce from mirror node account API
nonceCount = await this.getAccountLatestEthereumNonce(address, requestDetails);
return await this.getAccountLatestEthereumNonce(address, requestDetails);
} else if (blockNumOrTag === constants.BLOCK_EARLIEST) {
nonceCount = await this.getAccountNonceForEarliestBlock(requestDetails);
return await this.getAccountNonceForEarliestBlock(requestDetails);
} else if (!isNaN(blockNum) && blockNumOrTag.length != constants.BLOCK_HASH_LENGTH && blockNum > 0) {
nonceCount = await this.getAccountNonceForHistoricBlock(address, blockNum, requestDetails);
return await this.getAccountNonceForHistoricBlock(address, blockNum, requestDetails);
} else if (blockNumOrTag.length == constants.BLOCK_HASH_LENGTH && blockNumOrTag.startsWith(constants.EMPTY_HEX)) {
nonceCount = await this.getAccountNonceForHistoricBlock(address, blockNumOrTag, requestDetails);
} else {
// return a '-39001: Unknown block' error per api-spec
throw predefined.UNKNOWN_BLOCK();
return await this.getAccountNonceForHistoricBlock(address, blockNumOrTag, requestDetails);
}

const cacheTtl =
Copy link
Contributor

@konstantinabl konstantinabl Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natanasow shouldnt we keep the cache for the earliest block and specific block numbers?

Copy link
Member Author

@natanasow natanasow Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are cached on an upper level here https://github.com/hiero-ledger/hiero-json-rpc-relay/blob/main/packages/relay/src/lib/eth.ts#L928.

Copy link
Contributor

@konstantinabl konstantinabl Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

blockNumOrTag === constants.BLOCK_EARLIEST || !isNaN(blockNum)
? constants.CACHE_TTL.ONE_DAY
: this.ethGetTransactionCountCacheTtl; // cache historical values longer as they don't change
await this.cacheService.set(cacheKey, nonceCount, constants.ETH_GET_TRANSACTION_COUNT, cacheTtl);

return nonceCount;
// return a '-39001: Unknown block' error per api-spec
throw predefined.UNKNOWN_BLOCK();
}

/**
Expand Down
Loading