You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Is it acceptable to add a ctx context.Context parameter to some RDB and Inspector methods, for deadline, cancellation and observability(otel).
Describe the solution you'd like
Take Inspector.Queues() for example:
// QueuesContext returns a list of all queue names.func (i*Inspector) QueuesContext(ctx context.Context) ([]string, error) {
returni.rdb.AllQueuesContext(ctx)
}
// Queues returns a list of all queue names.func (i*Inspector) Queues() ([]string, error) {
returni.QueuesContext(context.Background())
}
// AllQueuesContext returns a list of all queue names.func (r*RDB) AllQueuesContext(ctx context.Context) ([]string, error) {
returnr.client.SMembers(ctx, base.AllQueues).Result()
}
// AllQueues returns a list of all queue names.func (r*RDB) AllQueues() ([]string, error) {
returnr.AllQueuesContext(context.Background())
}
I can make a PR if this is acceptable.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Is it acceptable to add a
ctx context.Context
parameter to someRDB
andInspector
methods, for deadline, cancellation and observability(otel).Describe the solution you'd like
Take
Inspector.Queues()
for example:I can make a PR if this is acceptable.
The text was updated successfully, but these errors were encountered: