Skip to content

Commit 2aac0bf

Browse files
committed
HV-1187 Update README.md with current JDK9 support
1 parent 84b3393 commit 2aac0bf

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

README.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,15 +79,18 @@ There are more build options available as well. For more information refer to [C
7979

8080
To build Hibernate Validator with JDK 9, export the following environment variable:
8181

82-
export MAVEN_OPTS="--add-modules java.annotations.common,java.xml.bind --add-opens=java.base/java.security=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED"
82+
export MAVEN_OPTS="--add-modules java.annotations.common,java.xml.bind --add-opens=java.base/java.security=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED"
8383

8484
Then the build can be started like this:
8585

86-
mvn -s settings-example.xml clean install -DdisableDocumentationBuild=true -DdisableDistributionBuild
86+
mvn -s settings-example.xml clean install
87+
88+
Also the OSGi integration tests will fail on Java 9 currently, hence the "osgi" module is excluded automatically when building on JDK 9. We are waiting for the release of Karaf 4.1.0.
8789

88-
The documentation and distribution modules are known to not work on Java 9 for the time being, hence they need to be excluded.
89-
Also the integration tests on WildFly will fail on Java 9 currently, hence this "integration" module is excluded automatically when building on JDK 9.
90+
Here are the reasons why we added the various --add-opens options:
9091

92+
* java.security: required by wildfly-maven-plugin:execute-commands (for the WildFly integration tests and the TCK runner running in container mode)
93+
* java.lang: required by JRuby for Asciidoc processing
9194

9295
## Continuous Integration
9396

0 commit comments

Comments
 (0)