Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework browser optimizeDeps #562

Closed
hi-ogawa opened this issue Jul 14, 2024 · 1 comment
Closed

rework browser optimizeDeps #562

hi-ogawa opened this issue Jul 14, 2024 · 1 comment

Comments

@hi-ogawa
Copy link
Owner

hi-ogawa commented Jul 14, 2024 •
edited
Loading

Current heuristics of optimizeDeps.entries: ["routes/**"] turns out to be a bit erroneous since it tries to pre-bundle entire server dependency and causes issues (warning?) for examples

It's not so critical since it shouldn't be that hard to manually identify such "server heavy" deps and configure by themselves, but the error message looks quite shocking at first for new users, so probably need to do something.

Simplest heuristic would be to crawl only local files (e.g. under app/) and find "use client" on our side, then use it as optimizeDeps.entries.
@hi-ogawa hi-ogawa mentioned this issue Jul 14, 2024
Closed
@hi-ogawa
Copy link
Owner Author

hi-ogawa commented Jul 15, 2024 •
edited
Loading

See #560 (comment)
Probably outing-out specific dependency (e.g. @node-rs/argon2, bcrypt) manually is simplest for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rework browser optimizeDeps.entries hi-ogawa/vite-plugins
1 participant
@hi-ogawa