head meta tag during SSR #397

hi-ogawa · 2024-06-13T06:46:01Z

Either introducing a whole export convention or maybe some helpers on top of React head float would be enough?

Assuming the need is mostly for SSR SEO, the issue is mostly due to naively using <title> will render duplicate tags.

vite-plugins/packages/react-server/examples/basic/e2e/basic.test.ts

Lines 748 to 752 in 4bf82b2

    
           // TODO: it doesn't magically overwrite already rendered title in the layout... 
        
           const res = await page.request.get("/test/head?title=hello"); 
        
           const resText = await res.text(); 
        
           expect(resText).toMatch(/<head>.*<title>rsc-experiment<\/title>.*<\/head>/s); 
        
           expect(resText).toMatch(/<head>.*<title>hello<\/title>.*<\/head>/s);

Something based on async context might be possible? (not possible to differentiate which page/layout render?)

The text was updated successfully, but these errors were encountered:

hi-ogawa changed the title ~~meta tag features~~ meta tag and head for seo Jun 13, 2024

hi-ogawa changed the title ~~meta tag and head for seo~~ head meta tag for SEO Jun 13, 2024

hi-ogawa changed the title ~~head meta tag for SEO~~ head meta tag during SSR Jun 13, 2024

hi-ogawa mentioned this issue Jun 27, 2024

feat: support metadata export #449

Merged

1 task

hi-ogawa closed this as completed in #449 Jun 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

head meta tag during SSR #397

head meta tag during SSR #397

hi-ogawa commented Jun 13, 2024 •

edited

Loading

head meta tag during SSR #397

head meta tag during SSR #397

Comments

hi-ogawa commented Jun 13, 2024 • edited Loading

hi-ogawa commented Jun 13, 2024 •

edited

Loading