Allow setting starting page as 0. #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm on board with this change, but you would want a test so it doesn't regress. |
|
Added the test. |
|
LGTM. We would need you to squash commits, then it can be merged. |
|
Updated. |
kellyselden
pushed a commit
that referenced
this pull request
Sep 29, 2015
Allow setting starting page as 0.
|
Thanks! |
|
TY!! |
|
@wuron - could you do a quick PR documenting this in the README? |
|
I'm not sure what to document here. Basically it's just a bugfix cause 0 was treated as falsy value so startingPage set to 0 was overriden with 1. |
|
@wuron oh right sorry just skimmed it! as you were |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.