bare minimum update work for ember 2 #79
Conversation
|
Or maybe #69 won't need additional rebasing, can't think of any conflicting changes right now. |
|
Let's see... |
|
Looks good to me. Man i really gotta figure out how to make vim strip whitespace... @mike-north - want to get your thoughts on the Ember Try stuff here. Also @kellyselden could u have a peeper ❤️ this is a big one! gonna be our first minor release....! |
| name: 'ember-release-with-proper-ember-data', | ||
| dependencies: { | ||
| 'ember': 'components/ember#release', | ||
| 'ember-data': '2.0.0-beta.2' |
There was a problem hiding this comment.
ember data 2.0 is no longer in beta
|
Hey @kellyselden, can you explain why ember-data is needed as a npm package and bower component, both? |
|
Hey @hhff, @kellyselden, @mike-north: Is there still something to do here apart from squashing the commits? |
|
I'll defer to @mike-north on that, he's the resident ember-try expert |
|
friendliest of friendly pings @mike-north |
| @@ -15,15 +15,12 @@ env: | |||
| - EMBER_TRY_SCENARIO=ember-1.12 | |||
| - EMBER_TRY_SCENARIO=ember-1.13 | |||
| - EMBER_TRY_SCENARIO=ember-release | |||
| - EMBER_TRY_SCENARIO=ember-release-ember-data-1.13.1x | |||
| - EMBER_TRY_SCENARIO=ember-beta | |||
| - EMBER_TRY_SCENARIO=ember-canary | |||
|
|
|||
| matrix: | |||
| fast_finish: true | |||
There was a problem hiding this comment.
there's no point in fast_finish if you have no allowed_failures
|
👍 once fixes are made |
|
Thanks @mike-north! Should be ready to go now! :) |
bare minimum update work for ember 2
|
YES! Nice one dudes! |
No description provided.