Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses the override properties when loading more #35

Merged
merged 1 commit into from
Jun 19, 2015
Merged

uses the override properties when loading more #35

merged 1 commit into from
Jun 19, 2015

Conversation

kellyselden
Copy link
Collaborator

fixes #34

@hhff
Copy link
Collaborator

hhff commented Jun 18, 2015

Thanks @kellyselden !! Figured this was the problem.

Currently tests aren't passing on Travis because we're not Ember 2.0 compatible yet (and ember-try is attempting to test against it). I won't have a chance to look into this until monday night coming.

@hhff
Copy link
Collaborator

hhff commented Jun 18, 2015

@kellyselden if you rebase against master, tests will now be passing. Keen to merge this!

@kellyselden
Copy link
Collaborator Author

Hopefully I can do this tonight

@kellyselden
Copy link
Collaborator Author

rebased

hhff added a commit that referenced this pull request Jun 19, 2015
uses the override properties when loading more
@hhff hhff merged commit d367cd1 into adopted-ember-addons:master Jun 19, 2015
@hhff
Copy link
Collaborator

hhff commented Jun 19, 2015

Da man

@kellyselden kellyselden deleted the load-more-override branch June 19, 2015 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

customizations not persisting
2 participants