Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub pages demo #22

Merged
merged 1 commit into from
May 23, 2015
Merged

GitHub pages demo #22

merged 1 commit into from
May 23, 2015

Conversation

mike-north
Copy link
Collaborator

More people should be using this addon. Having a demo page illustrating its usefulness will help :)

screen shot 2015-05-21 at 1 45 49 pm

mike-north
mike-north reviewed May 21, 2015
View reviewed changes
tests/acceptance/infinity-route-with-meta-test.js
@@ -48,7 +48,7 @@ module('Acceptance: Infinity Route', {
});

test('it works when meta is present in payload', assert => {
visit('/');
visit('/test');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-pathed the route used for acceptance tests, since there's more value in using the root URL / for humans

@mike-north mike-north force-pushed the github-pages-demo branch 3 times, most recently from 297418b to deb8d16 Compare May 21, 2015 23:00
@mike-north
Copy link
Collaborator Author

Live version of the page running on truenorth.github.io/ember-infinity

mike-north
mike-north reviewed May 21, 2015
View reviewed changes
package.json
@@ -23,16 +23,18 @@
"ember-cli-app-version": "0.3.3",
"ember-cli-content-security-policy": "0.4.0",
"ember-cli-dependency-checker": "^1.0.0",
"ember-cli-github-pages": "https://github.com/truenorth/ember-cli-github-pages.git#build-env",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependent on poetic/ember-cli-github-pages#17 , after which point I'll bring this project back onto mainline releases

@hhff
Copy link
Collaborator

hhff commented May 22, 2015

Hahah @truenorth you're a monster

guessing once this is merged, I'll just run ember github-pages:commit --message "Initial gh-pages release" and we're gravy?

Would be good to have a link to the GH pages demo in the Readme too!

you're the man - thankyou a million for your amazing work

@hhff
Copy link
Collaborator

hhff commented May 22, 2015

Also - looks like ur PR just got merged in

@mike-north
Copy link
Collaborator Author

I don't think this was merged. I have my own gh-pages branch in my fork

@mike-north
Copy link
Collaborator Author

To actually deploy this you may have to fiddle with it a little, but the basic idea is:

git checkout --orphan gh-pages && rm -rf `ls -a | grep -vE '.gitignore|.git|node_modules|bower_components|\.\/|\.\.\/'` && git add . && git commit -m "initial gh-pages commit"

to make a new branch, and then

ember github-pages:commit --message "Initial gh-pages release" --environment=development

to prepare your gh-pages branch for commit. You then have to manually push it, and it should work

@hhff
Copy link
Collaborator

hhff commented May 22, 2015

Oh I mean poetic/ember-cli-github-pages#17 was merged

@mike-north
Copy link
Collaborator Author

oh yes it was merged

@mike-north
Copy link
Collaborator Author

@hhff this branch now uses the newly released ember-cli-github-pages v0.0.5

hhff
hhff reviewed May 23, 2015
View reviewed changes
tests/dummy/app/routes/demo.js

tearDownPretender: Ember.observer('deactivate', function () {
this.set('pretender', undefined);
}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha this is cool

hhff added a commit that referenced this pull request May 23, 2015
@hhff
Merge pull request #22 from truenorth/github-pages-demo
2c9cff2 
GitHub pages demo
@hhff hhff merged commit 2c9cff2 into adopted-ember-addons:master May 23, 2015
@hhff
Copy link
Collaborator

hhff commented May 23, 2015

OK - so I ran

git checkout --orphan gh-pages && rm -rf `ls -a | grep -vE '.gitignore|.git|node_modules|bower_components|\.\/|\.\.\/'` && git add . && git commit -m "initial gh-pages commit"

And that checks out the new gh-pages branch, but doesn't actually make a commit:
screen shot 2015-05-23 at 4 11 23 pm

Then when I run:

ember github-pages:commit --message "Initial gh-pages release" --environment=development

I'm getting: The specified command github-pages:commit is invalid. For available options, see ember help.

Any thoughts @truenorth ? I'm a little too busy to fiddle around with this at the moment !

@mike-north
Copy link
Collaborator Author

@hhff if you give me contributor access, I'm happy to work out any kinks for you

@mike-north mike-north deleted the github-pages-demo branch May 23, 2015 07:29
@hhff
Copy link
Collaborator

hhff commented May 23, 2015

Will do when I get to a compu !
On Sat, 23 May 2015 at 4:28 pm Mike North [email protected] wrote:

@hhff https://github.com/hhff if you give me contributor access, I'm
happy to work out any kinks for you

—
Reply to this email directly or view it on GitHub
#22 (comment).

@mike-north
Copy link
Collaborator Author

@hhff awesome! I'm happy to help out with this great addon

@hhff
Copy link
Collaborator

hhff commented May 24, 2015

@truenorth - just gave u push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-north @hhff