Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds json response to README.md #19

Merged
merged 1 commit into from
May 20, 2015

Conversation

mockra
Copy link
Contributor

@mockra mockra commented May 20, 2015

wasn't clear from the documentation that the server needed to include
the number of total pages in the response

#12

I left the example data incomplete, since it would depend on each application.

Thanks!

@hhff
Copy link
Collaborator

hhff commented May 20, 2015

Thanks @mockra I think this should probably go up under basic usage though - it's a pretty important piece of info!

@mockra
Copy link
Contributor Author

mockra commented May 20, 2015

I moved the added documentation up under Basic Usage with an h4 tag.

When this is ready to be merged, I'll go ahead and squash the commits.

@hhff
Copy link
Collaborator

hhff commented May 20, 2015

👍 get squashy with it!!!

wasn't clear from the documentation that the server needed to include
the number of total pages in the response
@mockra
Copy link
Contributor Author

mockra commented May 20, 2015

squashed! thanks 😎

hhff added a commit that referenced this pull request May 20, 2015
adds json response to README.md
@hhff hhff merged commit b9f9429 into adopted-ember-addons:master May 20, 2015
@hhff
Copy link
Collaborator

hhff commented May 20, 2015

No thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants