Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only infinityLoad for this route's infinityModel #174

Merged

Conversation

jimmay5469
Copy link
Contributor

Fixes #150

Before calling this._infinityLoad(), double check that it's actually this route's loader which raised the infinityLoad action, otherwise bubble the infinityLoad action.

@hhff
Copy link
Collaborator

hhff commented Aug 8, 2016

Beautiful 👌

@hhff hhff merged commit 76ea696 into adopted-ember-addons:master Aug 8, 2016
@hhff
Copy link
Collaborator

hhff commented Aug 18, 2016

hi @rhengeveld - there's an easier way:

from within the component:
this.sendAction('action', this.get('infinityModel'));

and everything should be fine. I'd love a PR updating the docs?

@jimmay5469 jimmay5469 deleted the nested-infinity-routes-fix branch August 19, 2016 13:00
@jimmay5469
Copy link
Contributor Author

My bad for missing that one, I'll get you a PR in a couple minutes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants