Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new super format from init to avoid deprecation warnings #169

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Use new super format from init to avoid deprecation warnings #169

merged 1 commit into from
Jul 12, 2016

Conversation

mdentremont
Copy link
Contributor

@mdentremont mdentremont commented Jul 8, 2016

We have ember-infinity as a dependency and on newer versions of Ember we're getting a deprecation warning due to index.js not calling super from init:

DEPRECATION: Overriding init without calling this._super is deprecated. Please call `this._super.init && this._super.init.apply(this, arguments);` addon: `ember-infinity`
    at Function.Addon.lookup (/Users/mattdentremont/git/aiotv-admin/node_modules/ember-cli/lib/models/addon.js:896:27)

@mdentremont
Copy link
Contributor Author

The build failure might be due to a newer dependency -- I wonder if the master build would still pass if it we re-run (I think I tried this locally and it failed)?

@hhff
Copy link
Collaborator

hhff commented Jul 12, 2016

thanks @mdentremont ! I'm happy with this PR - but it looks like it's failing on Ember Beta. Do you wanna run the tests locally against ember beta (specifically 2.7.0-beta.2) and see what's going on?

@amoroz
Copy link

amoroz commented Jul 12, 2016

:frontend has failed to build: DEPRECATION: Overriding init without calling this._super is 
deprecated. Please call `this._super.init && this._super.init.apply(this, arguments);` addon: 
`ember-infinity`

We have the same deprecations after upgrading to ember-cli v2.6.2. So, waiting for the merge of that PR too 😸

@mdentremont
Copy link
Contributor Author

@hhff Yay! Looks like I just needed to rebase on top of master --- started off behind for some reason after forking.

@hhff hhff merged commit e2bb854 into adopted-ember-addons:master Jul 12, 2016
@hhff
Copy link
Collaborator

hhff commented Jul 12, 2016

perfect thankyou @mdentremont !

@mdentremont mdentremont deleted the topic/fix-deprecations branch July 12, 2016 15:30
@mdentremont
Copy link
Contributor Author

@hhff I had a bit of trouble with running the tests in an environment similar to you CI build. Mostly because you are using PhantomJS 2.0.0, which is not available through NPM :(

@amoroz
Copy link

amoroz commented Jul 12, 2016

@hhff @mdentremont thanks guys 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants