Skip pagination parameters when set to null

[ShogunPanda]

Hi.
In my server (which is based on cursor pagination) I have to make sure no extra parameters are set.
Therefore I try to set perPageParam and pageParam to null.

Unfortunately I noticed the parameters still get added like this:

$URL?...&null=2&...
I write a patch to completely exclude parameters when the names are not set.
Hope you like it!
Paolo

[hhff]

@ShogunPanda - I'm cool with this PR - but looks like some tests are failing!

[mphasize]

@ShogunPanda Any plans to get those tests working? This PR would be the missing puzzle piece for a nice solution to #157 :-)

[ShogunPanda]

@hhff I just rebased but even master (so without my changes) is failing for me locally while is passing on Travis.
What am I missing?

Could you please tell me exactly how to run tests (so far I've tried: ember try ember-1.10 test) so I can isolate my failures only?

Thanks!

[hhff]

Honestly, I'm not too sure. Ember Addon testing has been annoying flaky
for me over the last year.

It appears to be failing on the current version of Ember, so my guess is
that something has changed with the test setup.

I can't be sure right now I'm sorry :/ I don't have the time to work on
this currently - if you figure it out - please let me know!

On Tue, 6 Sep 2016 at 06:52 Shogun [email protected] wrote:

@hhff https://github.com/hhff I just rebased but even master (so
without my changes) is failing for me locally while is passing on Travis.
What am I missing?

Could you please tell me exactly how to run tests (so far I've tried: ember
try ember-1.10 test) so I can isolate my failures only?

Thanks!

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#147 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACu4_KbskwKXUzRTsOkz5d-2SQDfxLBbks5qnUXqgaJpZM4H0aq2
.

[ShogunPanda]

Hi again.
After a long while I checked the situation.

I think this fixed the issues. I just rebased and now all tests are passing.

Time to merge? 😉

[hhff]

Thanks so much @ShogunPanda !