Update README.md with requirements for the return value from afterInfinityModel #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| In the first example, afterInfinityModel does not have an explicit return | ||
| defined so the original posts promise result is used. In the second example, | ||
| the returned collection of authors is used. | ||
|
|
There was a problem hiding this comment.
Thankyou @chbonser !!
The developer can also return a promise to afterInfinityModel - in which case it will hold execution before populating the model. I'd like to be sure we document that too! It's a big part of the feature
…tyModel holds execution until it is resolved
|
@davidgoli thoughts? Plz merge if you're happy |
hhff
added a commit
that referenced
this pull request
Mar 11, 2016
Update README.md with requirements for the return value from afterInfinityModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #123