-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember-cli 1.13.8 -> 1.13.14 #129
ember-cli 1.13.8 -> 1.13.14 #129
Conversation
The only output of diff --git a/config/ember-try.js b/config/ember-try.js
index 85cbad5..3e88bc6 100644
--- a/config/ember-try.js
+++ b/config/ember-try.js
@@ -6,67 +6,30 @@ module.exports = {
dependencies: { }
},
{
- name: 'ember-1.10',
- dependencies: {
- ember: '~1.10.0',
- 'ember-data': '1.13.10'
- }
- },
- {
- name: 'ember-1.11',
- dependencies: {
- ember: '~1.11.3',
- 'ember-data': '1.13.10'
- }
- },
- {
- name: 'ember-1.12',
- dependencies: {
- ember: '~1.12.0'
- }
- },
- {
- name: 'ember-1.13',
- dependencies: {
- ember: '~1.13.0'
- }
- },
- {
name: 'ember-release',
dependencies: {
- ember: 'release',
- 'ember-data': 'release'
- }
- },
- {
- name: 'ember-release-ember-data-1.13.1x',
- dependencies: {
- ember: 'release',
- 'ember-data': '~1.13.11'
+ 'ember': 'components/ember#release'
},
resolutions: {
- ember: 'release',
- 'ember-data': '~1.13.11'
+ 'ember': 'release'
}
},
{
name: 'ember-beta',
dependencies: {
- ember: 'beta',
- 'ember-data': 'beta'
+ 'ember': 'components/ember#beta'
},
resolutions: {
- ember: 'beta'
+ 'ember': 'beta'
}
},
{
name: 'ember-canary',
dependencies: {
- ember: 'canary',
- 'ember-data': 'canary'
+ 'ember': 'components/ember#canary'
},
resolutions: {
- ember: 'canary'
+ 'ember': 'canary'
}
}
] |
@@ -15,5 +15,3 @@ | |||
/libpeerconnection.log | |||
npm-debug.log | |||
testem.log | |||
|
|||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep .DS_Store
in here plz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that be in your global .gitignore? To keep this .gitignore focused on ember-infinity. And so you don't have to add your personal ignores to every project you work on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@john-kurkowski I would agree, since this wouldn't affect Linux or Windows users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er, was that a vote for keeping .DS_Store
in this file or removing it? 😄 Up to you both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha sorry, I'm in favor of removing it from the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair shake! agree'd
@john-kurkowski can we merge master here please! |
ab7e9b9
to
de5f96f
Compare
Rebased to fix conflict. |
Ahh sorry @john-kurkowski - missed this THANKYOU |
Accept
ember init
's output, except for ember-infinity-specific dependencies.Acquires all the goodies and bugfixes in the last few releases of ember-cli.