Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-cli 1.13.8 -> 1.13.14 #129

Merged
merged 1 commit into from
Feb 12, 2016

Conversation

john-kurkowski
Copy link
Contributor

Accept ember init's output, except for ember-infinity-specific dependencies.

Acquires all the goodies and bugfixes in the last few releases of ember-cli.

@john-kurkowski
Copy link
Contributor Author

The only output of ember init I wasn't sure about was config/ember-try.js. I'm not familiar with that file. So I left it alone. Patch:

diff --git a/config/ember-try.js b/config/ember-try.js
index 85cbad5..3e88bc6 100644
--- a/config/ember-try.js
+++ b/config/ember-try.js
@@ -6,67 +6,30 @@ module.exports = {
       dependencies: { }
     },
     {
-      name: 'ember-1.10',
-      dependencies: {
-        ember: '~1.10.0',
-        'ember-data': '1.13.10'
-      }
-    },
-    {
-      name: 'ember-1.11',
-      dependencies: {
-        ember: '~1.11.3',
-        'ember-data': '1.13.10'
-      }
-    },
-    {
-      name: 'ember-1.12',
-      dependencies: {
-        ember: '~1.12.0'
-      }
-    },
-    {
-      name: 'ember-1.13',
-      dependencies: {
-        ember: '~1.13.0'
-      }
-    },
-    {
       name: 'ember-release',
       dependencies: {
-        ember: 'release',
-        'ember-data': 'release'
-      }
-    },
-    {
-      name: 'ember-release-ember-data-1.13.1x',
-      dependencies: {
-        ember: 'release',
-        'ember-data': '~1.13.11'
+        'ember': 'components/ember#release'
       },
       resolutions: {
-        ember: 'release',
-        'ember-data': '~1.13.11'
+        'ember': 'release'
       }
     },
     {
       name: 'ember-beta',
       dependencies: {
-        ember: 'beta',
-        'ember-data': 'beta'
+        'ember': 'components/ember#beta'
       },
       resolutions: {
-        ember: 'beta'
+        'ember': 'beta'
       }
     },
     {
       name: 'ember-canary',
       dependencies: {
-        ember: 'canary',
-        'ember-data': 'canary'
+        'ember': 'components/ember#canary'
       },
       resolutions: {
-        ember: 'canary'
+        'ember': 'canary'
       }
     }
   ]

@@ -15,5 +15,3 @@
/libpeerconnection.log
npm-debug.log
testem.log

.DS_Store
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep .DS_Store in here plz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be in your global .gitignore? To keep this .gitignore focused on ember-infinity. And so you don't have to add your personal ignores to every project you work on.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@john-kurkowski I would agree, since this wouldn't affect Linux or Windows users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er, was that a vote for keeping .DS_Store in this file or removing it? 😄 Up to you both.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha sorry, I'm in favor of removing it from the file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair shake! agree'd

@hhff
Copy link
Collaborator

hhff commented Jan 14, 2016

@john-kurkowski can we merge master here please!

@john-kurkowski
Copy link
Contributor Author

Rebased to fix conflict.

hhff added a commit that referenced this pull request Feb 12, 2016
@hhff hhff merged commit b6cb07a into adopted-ember-addons:master Feb 12, 2016
@hhff
Copy link
Collaborator

hhff commented Feb 12, 2016

Ahh sorry @john-kurkowski - missed this

THANKYOU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants