-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add afterInfinityModel #105
Conversation
bbd74f4
to
343f6a7
Compare
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "ember-infinity", | |||
"version": "0.2.0-beta.1", | |||
"version": "0.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually bump the version separate to a PR @davidgoli - can you please remove this file from the PR?
} | ||
}, | ||
afterInfinityModel(items) { | ||
return items.setEach('author', 'F. Scott Fitzgerald'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this test doesn't actually test that - in fact it's identical to the test above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a feature we need first-order support for anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can implement that separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NM this is supported, it's just that test wasn't testing it
c4a3076
to
d22dcf3
Compare
d22dcf3
to
33d9105
Compare
@hhff updated! |
awesome work @kxcrl & @davidgoli - I'm doing a lightning talk at EmberNYC next week - going to be showing off this awesome feature 👍 |
@hhff Awesome! Good luck! |
Hello! I'm having duplicated results on latest 0.2.1 model() {
return this.infinityModel('wall/event', {
perPage: 6,
startingPage: 0,
q:'relevant'
});
} Cheers! |
This supercedes #77 with all changes made.