-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_bindScroll in infinity-loader.js sets wrong scroll element #5
Comments
Hi @temo44 ! Thanks for this! Check this link. It explains why we're using the Also - check out the latest release (just released this morning) #4 - it now has a "scrollable" attribute that can be used to pass in a selector string 😄 |
Thank you for the reply @hhff ! It makes total sense. However, won't the selector still be incorrect, as Ember generates infinity-loader's guid as an ID, and not a class? Cool that the feature is introduced 😄. Awesome addon btw! |
Thanks @temo44 ! The guid is only used as the event namespace - ie: the unique string that "scrollable" (usually the window) uses to identify the event name. It's not a selector - it's a scroll event with a unique namespace. it could be Ember.$(scrollElement).on("scroll."+Math.random(), function() { But a GUID is guaranteed to be unique. make sense? |
Aaah thanks! It totally makes sense now. I know where my thought process went wrong 😄 ! I still thought it was part of the 'not-scrolling' problem(hence, the idea that it's a selector instead of a namespace), because I have a different scrolling element. Thank you so much! |
There is actually one issue and one suggestion :)
the html to support the ID assigning (how it's rendered):
infinity-loader.js
should be
will be
The text was updated successfully, but these errors were encountered: