Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Ember 2.0 #32

Closed
hhff opened this issue Jun 17, 2015 · 13 comments
Closed

Update for Ember 2.0 #32

hhff opened this issue Jun 17, 2015 · 13 comments

Comments

@hhff
Copy link
Collaborator

hhff commented Jun 17, 2015

No description provided.

@timohermans
Copy link

Any news on this? When updating to Ember 1.13, I get a deprecated warning on the this.store.find method in the mixin.

It should now be .query() :p

@hhff
Copy link
Collaborator Author

hhff commented Jun 25, 2015

word! haven't had a chance to look into it as of yet.

@hhff
Copy link
Collaborator Author

hhff commented Jun 26, 2015

@temo44 - letting you know that I should have something soon. See: ember-cli/ember-cli#4339

hhff added a commit that referenced this issue Jun 28, 2015
hhff added a commit that referenced this issue Jun 28, 2015
@varoot
Copy link

varoot commented Jul 10, 2015

I'm patiently waiting for this. Let me know if you need help testing it.

@hhff
Copy link
Collaborator Author

hhff commented Jul 10, 2015

Thanks @varoot - i just need a chance to write a test for #48 and I thinkkkk we're good

@crunchtime-ali
Copy link
Contributor

@hhff:
Now that Ember 2.0 is officially out will you merge the commit?

@hhff
Copy link
Collaborator Author

hhff commented Aug 13, 2015

@dj-hedgehog ill merge it when I get a chance to finish it. juggling 4 clients at the moment, violins, sad music etc etc

@mike-north
Copy link
Collaborator

I'll soon need to handle this if it's not addressed soon. @hhff can you brain dump any "ember-infinity for ember 2.0" thoughts/plans on this ticket

@ghost
Copy link

ghost commented Aug 17, 2015

Hey @hhff, Hey @mike-north,

I will look into updating ember-infinity to 2.0 this week. Or are you, @mike-north, already working on a PR with updates for 2.0?

@mike-north
Copy link
Collaborator

I have no code written for this yet, but am eager to get this addon working with the current ember release

@hhff
Copy link
Collaborator Author

hhff commented Aug 17, 2015

@mike-north sorry just saw your note above!

I think the first iteration re: 2.0 stuff should be to get everything working as minimal as possible. Getting my ED 1.13.x branch in will help. (I'm stacked 12 hour days for another couple weeks)

Been looking at https://github.com/mixonic/ember-cli-deprecation-workflow as a possible way to handle the transition between Ember Data versions.

The next big feature for this lib will be allowing it to work sans-Ember Data. It's not totally unrelated to the update to 2.0, as we'll need the concept of a "promise generator" for the infinityRoute.

Also, once we're 2.0 compatible, I'm keen to cut the first release on 0.1.x track!

@mike-north
Copy link
Collaborator

Perhaps a good temporary solution to un-block people is to have an ember-data-2 branch that people can point to. This would mean that the code can be different (i.e., the new store API) from what's needed for ember-data 1.x, with no need to figure out how to support both at the same time.

When the tight coupling to ember-data is removed, this will become a non-issue. Perhaps we never will even need to solve the hard problem (maintaining support for ED 1.x and 2.x at the same time)

@hhff
Copy link
Collaborator Author

hhff commented Aug 17, 2015

jah, #48 just needs a test, and should be fine.

u know what, I'll do it first thing tomorrow

hhff added a commit that referenced this issue Aug 19, 2015
hhff added a commit that referenced this issue Aug 20, 2015
hhff added a commit that referenced this issue Aug 20, 2015
@hhff hhff closed this as completed in 320a547 Aug 20, 2015
mike-north added a commit that referenced this issue Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants