Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade from 0.0.4 to 0.0.8 causes Cannot find module 'ember-cli-version-checker' #27

Closed
ashrafhasson opened this issue Jun 12, 2015 · 4 comments

Comments

@ashrafhasson
Copy link
Contributor

Hi there,

Thanks for the awesome addon.
I've just upgraded from 0.0.4 to 0.0.8 and now it shows the error:

Cannot find module 'ember-cli-version-checker'

when starting with ember s. While I can certainly include it in my package.json, I wonder whether this was meant to be included as a dependency for the app to include?

@cgwic
Copy link

cgwic commented Jun 12, 2015

its about (discoursinng)
[https://github.com//pull/26]
or u can use (my fork)[https://github.com/cgwic/ember-infinity] with all compatible to ember-infinity
im using it with my [https://github.com/cgwic/stream-fan] on openshift [http://streamfan-cgwic.rhcloud.com]

@hhff
Copy link
Collaborator

hhff commented Jun 12, 2015

Looks like it belongs in dependencies, not devDependencies

@hhff
Copy link
Collaborator

hhff commented Jun 12, 2015

@cgwic just merged your PR; sorry it was hanging!! Will cut 0.0.9 shortly

@hhff hhff closed this as completed Jun 12, 2015
@hhff
Copy link
Collaborator

hhff commented Jun 12, 2015

just tried this with 0.0.9 in a fresh CLI app, and all is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants