Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metadata client error detection #193

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fix metadata client error detection #193

merged 1 commit into from
Apr 26, 2022

Conversation

choffmeister
Copy link
Contributor

Fixes two issues:

  1. Metadata client does not recognise unsuccessful HTTP response codes
  2. Closed a potential memory leak (not closed HTTP response)

@LKaemmerling LKaemmerling merged commit 02a12f0 into hetznercloud:main Apr 26, 2022
@LKaemmerling
Copy link
Member

Hey @choffmeister,

thank you good catch!

@choffmeister choffmeister deleted the fix-metadata-client branch April 26, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@choffmeister @LKaemmerling