feat: allow retrieving the action from an action error #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 71.47% 71.44% -0.03%
==========================================
Files 46 46
Lines 3930 3933 +3
==========================================
+ Hits 2809 2810 +1
- Misses 709 711 +2
Partials 412 412 ☔ View full report in Codecov by Sentry. |
When an action error occur within the actions waiter utilities, we are laking information about the related action that failed. With this change, we can now retrieve the action that triggered the failure after casting the error to an action error.
|
API is similar to this one https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#Error.Response |
apricote
approved these changes
Oct 16, 2024
jooola
pushed a commit
that referenced
this pull request
Oct 21, 2024
🤖 I have created a release *beep* *boop* --- ## [2.14.0](v2.13.1...v2.14.0) (2024-10-21) ### Features * add support for Go 1.23 ([#532](#532)) ([838f878](838f878)) * allow retrieving the action from an action error ([#538](#538)) ([07727d3](07727d3)) * include action ID in action error string ([#539](#539)) ([ad5417f](ad5417f)) ### Bug Fixes * deprecate pricing floating ip field ([#523](#523)) ([1089d40](1089d40)) * deprecate unused window parameter in the `EnableBackup` call ([#531](#531)) ([584f6c2](584f6c2)), closes [#525](#525) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Oct 21, 2024
…4.0 (hetznercloud/fleeting-plugin-hetzner!141) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.13.1` -> `v2.14.0` | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.14.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.14.0) [Compare Source](hetznercloud/hcloud-go@v2.13.1...v2.14.0) ##### Features - add support for Go 1.23 ([#​532](hetznercloud/hcloud-go#532)) ([838f878](hetznercloud/hcloud-go@838f878)) - allow retrieving the action from an action error ([#​538](hetznercloud/hcloud-go#538)) ([07727d3](hetznercloud/hcloud-go@07727d3)) - include action ID in action error string ([#​539](hetznercloud/hcloud-go#539)) ([ad5417f](hetznercloud/hcloud-go@ad5417f)) ##### Bug Fixes - deprecate pricing floating ip field ([#​523](hetznercloud/hcloud-go#523)) ([1089d40](hetznercloud/hcloud-go@1089d40)) - deprecate unused window parameter in the `EnableBackup` call ([#​531](hetznercloud/hcloud-go#531)) ([584f6c2](hetznercloud/hcloud-go@584f6c2)), closes [#​525](hetznercloud/hcloud-go#525) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjguNiIsInVwZGF0ZWRJblZlciI6IjM4LjEyOC42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an action error occurs within the action waiter utilities, we are missing information about the related action that failed. With this change, we can now retrieve the action that triggered the failure after casting the error to an action error.