Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter out nil actions in action waiter #464

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Jun 19, 2024

Filter out nil actions, to help users of the function.

@jooola jooola requested a review from a team as a code owner June 19, 2024 09:54
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.92%. Comparing base (895ada1) to head (1bfcdbc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   70.91%   70.92%           
=======================================
  Files          36       36           
  Lines        3799     3800    +1     
=======================================
+ Hits         2694     2695    +1     
  Misses        692      692           
  Partials      413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 4fc9a40 into hetznercloud:main Jun 19, 2024
4 checks passed
@jooola jooola deleted the filter-out-nil-actions branch June 19, 2024 13:47
jooola added a commit that referenced this pull request Jun 25, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.10.0](v2.9.0...v2.10.0)
(2024-06-25)


### Features

* **exp:** add envutils package
([#466](#466))
([a7636bd](a7636bd))
* **exp:** add labelutils with selector
([#465](#465))
([1a55a7e](1a55a7e))
* **exp:** add mock utils package
([#460](#460))
([92f7c62](92f7c62))
* **exp:** rename `AppendNextActions` to `AppendNext`
([#452](#452))
([9b6239a](9b6239a))
* filter out nil actions in action waiter
([#464](#464))
([4fc9a40](4fc9a40))


### Bug Fixes

* nil check against the embedded `http.Response`
([#469](#469))
([46e489a](46e489a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jonas L <[email protected]>
@jooola jooola added the backport release-1.x Open PR against release-1.x with these changes after the PR is merged. label Jun 25, 2024
Copy link
Contributor

The backport to release-1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.x release-1.x
# Navigate to the new working tree
cd .worktrees/backport-release-1.x
# Create a new branch
git switch --create backport-464-to-release-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4fc9a4039d45071124a435121642ca396a8237c0
# Push it to GitHub
git push --set-upstream origin backport-464-to-release-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.x

Then, create a pull request where the base branch is release-1.x and the compare/head branch is backport-464-to-release-1.x.

jooola added a commit to jooola/hcloud-go that referenced this pull request Jun 25, 2024
Filter out nil actions, to help users of the function.
jooola added a commit that referenced this pull request Jun 25, 2024
Filter out nil actions, to help users of the function.

Backport commit 4fc9a40 into
release-1.x
jooola pushed a commit that referenced this pull request Jun 25, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.57.0](v1.56.0...v1.57.0)
(2024-06-25)


### Features

* filter out nil actions in action waiter
([#464](#464))
([#471](#471))
([14bf589](14bf589))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Sep 12, 2024
…0.2 (hetznercloud/fleeting-plugin-hetzner!83)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.9.0` -> `v2.10.2` |

---

### Release Notes

<details>
<summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary>

### [`v2.10.2`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.10.2)

[Compare Source](hetznercloud/hcloud-go@v2.10.1...v2.10.2)

##### Bug Fixes

-   **exp:** allow request path matching in the want function ([#&#8203;475](hetznercloud/hcloud-go#475)) ([267879b](hetznercloud/hcloud-go@267879b))

### [`v2.10.1`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.10.1)

[Compare Source](hetznercloud/hcloud-go@v2.10.0...v2.10.1)

##### Bug Fixes

-   **exp:** configure response headers before sending them ([#&#8203;473](hetznercloud/hcloud-go#473)) ([07d4a35](hetznercloud/hcloud-go@07d4a35))

### [`v2.10.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.10.0)

[Compare Source](hetznercloud/hcloud-go@v2.9.0...v2.10.0)

##### Features

-   **exp:** add envutils package ([#&#8203;466](hetznercloud/hcloud-go#466)) ([a7636bd](hetznercloud/hcloud-go@a7636bd))
-   **exp:** add labelutils with selector ([#&#8203;465](hetznercloud/hcloud-go#465)) ([1a55a7e](hetznercloud/hcloud-go@1a55a7e))
-   **exp:** add mock utils package ([#&#8203;460](hetznercloud/hcloud-go#460)) ([92f7c62](hetznercloud/hcloud-go@92f7c62))
-   **exp:** rename `AppendNextActions` to `AppendNext` ([#&#8203;452](hetznercloud/hcloud-go#452)) ([9b6239a](hetznercloud/hcloud-go@9b6239a))
-   filter out nil actions in action waiter ([#&#8203;464](hetznercloud/hcloud-go#464)) ([4fc9a40](hetznercloud/hcloud-go@4fc9a40))

##### Bug Fixes

-   nil check against the embedded `http.Response` ([#&#8203;469](hetznercloud/hcloud-go#469)) ([46e489a](hetznercloud/hcloud-go@46e489a))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxOC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.x Open PR against release-1.x with these changes after the PR is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants