Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exp): add mock utils package #460

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Jun 18, 2024

Test helper to mock http request made with the hcloud-go library.

@jooola jooola requested a review from a team as a code owner June 18, 2024 10:07
@jooola jooola requested a review from apricote June 18, 2024 10:08
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.91%. Comparing base (8c7f5b3) to head (b1cb5df).

Current head b1cb5df differs from pull request most recent head 8e3a827

Please upload reports for the commit 8e3a827 to get more accurate results.

Files Patch % Lines
hcloud/exp/kit/mockutils/mockutils.go 70.37% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   70.91%   70.91%   -0.01%     
==========================================
  Files          35       36       +1     
  Lines        3772     3799      +27     
==========================================
+ Hits         2675     2694      +19     
- Misses        688      692       +4     
- Partials      409      413       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hcloud-bot

This comment was marked as off-topic.

Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding a example that shows how you can use this with hcloud-go?

@jooola
Copy link
Member Author

jooola commented Jun 18, 2024

What do you think about adding a example that shows how you can use this with hcloud-go?

Hmm, I need an actual *testing.T for the handler to work. I believe I don't have access to this inside an example.

The existing test case is already an example; it will not show in the docs, though.

@jooola jooola merged commit 92f7c62 into hetznercloud:main Jun 18, 2024
4 checks passed
@jooola jooola deleted the mock-utils branch June 18, 2024 11:13
jooola added a commit that referenced this pull request Jun 18, 2024
Removes the now duplicated mock request utils, and uses the one
introduced in #460.
jooola added a commit that referenced this pull request Jun 25, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.10.0](v2.9.0...v2.10.0)
(2024-06-25)


### Features

* **exp:** add envutils package
([#466](#466))
([a7636bd](a7636bd))
* **exp:** add labelutils with selector
([#465](#465))
([1a55a7e](1a55a7e))
* **exp:** add mock utils package
([#460](#460))
([92f7c62](92f7c62))
* **exp:** rename `AppendNextActions` to `AppendNext`
([#452](#452))
([9b6239a](9b6239a))
* filter out nil actions in action waiter
([#464](#464))
([4fc9a40](4fc9a40))


### Bug Fixes

* nil check against the embedded `http.Response`
([#469](#469))
([46e489a](46e489a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jonas L <[email protected]>
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Sep 12, 2024
…0.2 (hetznercloud/fleeting-plugin-hetzner!83)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.9.0` -> `v2.10.2` |

---

### Release Notes

<details>
<summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary>

### [`v2.10.2`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.10.2)

[Compare Source](hetznercloud/hcloud-go@v2.10.1...v2.10.2)

##### Bug Fixes

-   **exp:** allow request path matching in the want function ([#&#8203;475](hetznercloud/hcloud-go#475)) ([267879b](hetznercloud/hcloud-go@267879b))

### [`v2.10.1`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.10.1)

[Compare Source](hetznercloud/hcloud-go@v2.10.0...v2.10.1)

##### Bug Fixes

-   **exp:** configure response headers before sending them ([#&#8203;473](hetznercloud/hcloud-go#473)) ([07d4a35](hetznercloud/hcloud-go@07d4a35))

### [`v2.10.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.10.0)

[Compare Source](hetznercloud/hcloud-go@v2.9.0...v2.10.0)

##### Features

-   **exp:** add envutils package ([#&#8203;466](hetznercloud/hcloud-go#466)) ([a7636bd](hetznercloud/hcloud-go@a7636bd))
-   **exp:** add labelutils with selector ([#&#8203;465](hetznercloud/hcloud-go#465)) ([1a55a7e](hetznercloud/hcloud-go@1a55a7e))
-   **exp:** add mock utils package ([#&#8203;460](hetznercloud/hcloud-go#460)) ([92f7c62](hetznercloud/hcloud-go@92f7c62))
-   **exp:** rename `AppendNextActions` to `AppendNext` ([#&#8203;452](hetznercloud/hcloud-go#452)) ([9b6239a](hetznercloud/hcloud-go@9b6239a))
-   filter out nil actions in action waiter ([#&#8203;464](hetznercloud/hcloud-go#464)) ([4fc9a40](hetznercloud/hcloud-go@4fc9a40))

##### Bug Fixes

-   nil check against the embedded `http.Response` ([#&#8203;469](hetznercloud/hcloud-go#469)) ([46e489a](hetznercloud/hcloud-go@46e489a))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxOC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants