-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add volume format property #397
Conversation
This property was previously missing, although it was already used in VolumeCreateOpts. It's now a string pointer with common values (ext4 and xfs) available as string constants.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
=======================================
Coverage 80.34% 80.35%
=======================================
Files 32 32
Lines 5729 5731 +2
=======================================
+ Hits 4603 4605 +2
Misses 718 718
Partials 408 408 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jonas L. <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [2.7.0](v2.6.0...v2.7.0) (2024-03-27) ### Features * add volume format property ([#397](#397)) ([c0940af](c0940af)) * **error:** handle wrapped errors in IsError() ([#374](#374)) ([83df108](83df108)) * require Go >= 1.20 ([#392](#392)) ([299f181](299f181)) * **server:** deprecate ServerRescueTypeLinux32 ([#378](#378)) ([2f334c3](2f334c3)) * test with Go 1.22 ([#391](#391)) ([49be506](49be506)) ### Bug Fixes * falsely omitted fields in firewall schema ([#396](#396)) ([a3509b6](a3509b6)) * LoadBalancerUpdateServiceOpts not converted correctly ([#394](#394)) ([0f187ce](0f187ce)) * primary ip assignee id not mapped to nil ([#395](#395)) ([b5fea38](b5fea38)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.x release-1.x
# Navigate to the new working tree
cd .worktrees/backport-release-1.x
# Create a new branch
git switch --create backport-397-to-release-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0940afce9eb01c0e6838502c91aa569ab411a03
# Push it to GitHub
git push --set-upstream origin backport-397-to-release-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.x Then, create a pull request where the |
@phm07 Can you backport this? |
This property was previously missing, although it was already used in VolumeCreateOpts. It's now a string pointer with common values (ext4 and xfs) available as string constants. --------- Co-authored-by: pauhull <[email protected]> Co-authored-by: Jonas L. <[email protected]> (cherry picked from commit c0940af)
This property was previously missing, although it was already used in VolumeCreateOpts. It's now a string pointer with common values (ext4 and xfs) available as string constants. (cherry picked from commit c0940af) BEGIN_COMMIT_OVERRIDE feat: add volume format property END_COMMIT_OVERRIDE
…etznercloud/fleeting-plugin-hetzner!38) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.6.0` -> `v2.7.2` | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.7.2`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.7.2) [Compare Source](hetznercloud/hcloud-go@v2.7.1...v2.7.2) ##### Bug Fixes - creating firewall with rules not working correctly ([#​412](hetznercloud/hcloud-go#412)) ([43b2bab](hetznercloud/hcloud-go@43b2bab)) ### [`v2.7.1`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.7.1) [Compare Source](hetznercloud/hcloud-go@v2.7.0...v2.7.1) ##### Bug Fixes - setting firewall rules not working correctly ([#​405](hetznercloud/hcloud-go#405)) ([16daea0](hetznercloud/hcloud-go@16daea0)) ### [`v2.7.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.7.0) [Compare Source](hetznercloud/hcloud-go@v2.6.0...v2.7.0) ##### Features - add volume format property ([#​397](hetznercloud/hcloud-go#397)) ([c0940af](hetznercloud/hcloud-go@c0940af)) - **error:** handle wrapped errors in IsError() ([#​374](hetznercloud/hcloud-go#374)) ([83df108](hetznercloud/hcloud-go@83df108)) - require Go >= 1.20 ([#​392](hetznercloud/hcloud-go#392)) ([299f181](hetznercloud/hcloud-go@299f181)) - **server:** deprecate ServerRescueTypeLinux32 ([#​378](hetznercloud/hcloud-go#378)) ([2f334c3](hetznercloud/hcloud-go@2f334c3)) - test with Go 1.22 ([#​391](hetznercloud/hcloud-go#391)) ([49be506](hetznercloud/hcloud-go@49be506)) ##### Bug Fixes - falsely omitted fields in firewall schema ([#​396](hetznercloud/hcloud-go#396)) ([a3509b6](hetznercloud/hcloud-go@a3509b6)) - LoadBalancerUpdateServiceOpts not converted correctly ([#​394](hetznercloud/hcloud-go#394)) ([0f187ce](hetznercloud/hcloud-go@0f187ce)) - primary ip assignee id not mapped to nil ([#​395](hetznercloud/hcloud-go#395)) ([b5fea38](hetznercloud/hcloud-go@b5fea38)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjQuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyNC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
This property was previously missing, although it was already used in VolumeCreateOpts. It's now a string pointer with common values (ext4 and xfs) available as string constants.