Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add volume format property #397

Merged
merged 2 commits into from
Mar 7, 2024
Merged

feat: add volume format property #397

merged 2 commits into from
Mar 7, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Mar 7, 2024

This property was previously missing, although it was already used in VolumeCreateOpts. It's now a string pointer with common values (ext4 and xfs) available as string constants.

This property was previously missing, although it was already used in VolumeCreateOpts. It's now a string pointer with common values (ext4 and xfs) available as string constants.
@phm07 phm07 added the Feature label Mar 7, 2024
@phm07 phm07 self-assigned this Mar 7, 2024
@phm07 phm07 requested a review from a team as a code owner March 7, 2024 11:20
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.35%. Comparing base (49be506) to head (f22592a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   80.34%   80.35%           
=======================================
  Files          32       32           
  Lines        5729     5731    +2     
=======================================
+ Hits         4603     4605    +2     
  Misses        718      718           
  Partials      408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hcloud/volume.go Outdated Show resolved Hide resolved
hcloud/volume.go Outdated Show resolved Hide resolved
@phm07 phm07 merged commit c0940af into main Mar 7, 2024
5 checks passed
@phm07 phm07 deleted the add-volume-format branch March 7, 2024 14:29
apricote pushed a commit that referenced this pull request Mar 27, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.7.0](v2.6.0...v2.7.0)
(2024-03-27)


### Features

* add volume format property
([#397](#397))
([c0940af](c0940af))
* **error:** handle wrapped errors in IsError()
([#374](#374))
([83df108](83df108))
* require Go >= 1.20
([#392](#392))
([299f181](299f181))
* **server:** deprecate ServerRescueTypeLinux32
([#378](#378))
([2f334c3](2f334c3))
* test with Go 1.22
([#391](#391))
([49be506](49be506))


### Bug Fixes

* falsely omitted fields in firewall schema
([#396](#396))
([a3509b6](a3509b6))
* LoadBalancerUpdateServiceOpts not converted correctly
([#394](#394))
([0f187ce](0f187ce))
* primary ip assignee id not mapped to nil
([#395](#395))
([b5fea38](b5fea38))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@apricote apricote added the backport release-1.x Open PR against release-1.x with these changes after the PR is merged. label Apr 11, 2024
Copy link
Contributor

The backport to release-1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.x release-1.x
# Navigate to the new working tree
cd .worktrees/backport-release-1.x
# Create a new branch
git switch --create backport-397-to-release-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0940afce9eb01c0e6838502c91aa569ab411a03
# Push it to GitHub
git push --set-upstream origin backport-397-to-release-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.x

Then, create a pull request where the base branch is release-1.x and the compare/head branch is backport-397-to-release-1.x.

@apricote
Copy link
Member

@phm07 Can you backport this?

phm07 added a commit that referenced this pull request May 21, 2024
This property was previously missing, although it was already used in
VolumeCreateOpts. It's now a string pointer with common values (ext4 and
xfs) available as string constants.

---------

Co-authored-by: pauhull <[email protected]>
Co-authored-by: Jonas L. <[email protected]>

(cherry picked from commit c0940af)
@phm07
Copy link
Contributor Author

phm07 commented May 21, 2024

@phm07 Can you backport this?

Done in #444

apricote pushed a commit that referenced this pull request May 22, 2024
This property was previously missing, although it was already used in
VolumeCreateOpts. It's now a string pointer with common values (ext4 and
xfs) available as string constants.

(cherry picked from commit c0940af)

BEGIN_COMMIT_OVERRIDE
feat: add volume format property
END_COMMIT_OVERRIDE
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Sep 12, 2024
…etznercloud/fleeting-plugin-hetzner!38)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.6.0` -> `v2.7.2` |

---

### Release Notes

<details>
<summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary>

### [`v2.7.2`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.7.2)

[Compare Source](hetznercloud/hcloud-go@v2.7.1...v2.7.2)

##### Bug Fixes

-   creating firewall with rules not working correctly ([#&#8203;412](hetznercloud/hcloud-go#412)) ([43b2bab](hetznercloud/hcloud-go@43b2bab))

### [`v2.7.1`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.7.1)

[Compare Source](hetznercloud/hcloud-go@v2.7.0...v2.7.1)

##### Bug Fixes

-   setting firewall rules not working correctly ([#&#8203;405](hetznercloud/hcloud-go#405)) ([16daea0](hetznercloud/hcloud-go@16daea0))

### [`v2.7.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.7.0)

[Compare Source](hetznercloud/hcloud-go@v2.6.0...v2.7.0)

##### Features

-   add volume format property ([#&#8203;397](hetznercloud/hcloud-go#397)) ([c0940af](hetznercloud/hcloud-go@c0940af))
-   **error:** handle wrapped errors in IsError() ([#&#8203;374](hetznercloud/hcloud-go#374)) ([83df108](hetznercloud/hcloud-go@83df108))
-   require Go >= 1.20 ([#&#8203;392](hetznercloud/hcloud-go#392)) ([299f181](hetznercloud/hcloud-go@299f181))
-   **server:** deprecate ServerRescueTypeLinux32 ([#&#8203;378](hetznercloud/hcloud-go#378)) ([2f334c3](hetznercloud/hcloud-go@2f334c3))
-   test with Go 1.22 ([#&#8203;391](hetznercloud/hcloud-go#391)) ([49be506](hetznercloud/hcloud-go@49be506))

##### Bug Fixes

-   falsely omitted fields in firewall schema ([#&#8203;396](hetznercloud/hcloud-go#396)) ([a3509b6](hetznercloud/hcloud-go@a3509b6))
-   LoadBalancerUpdateServiceOpts not converted correctly ([#&#8203;394](hetznercloud/hcloud-go#394)) ([0f187ce](hetznercloud/hcloud-go@0f187ce))
-   primary ip assignee id not mapped to nil ([#&#8203;395](hetznercloud/hcloud-go#395)) ([b5fea38](hetznercloud/hcloud-go@b5fea38))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjQuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyNC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.x Open PR against release-1.x with these changes after the PR is merged. Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants