fix: falsely omitted fields in firewall schema

[phm07]

In the API Docs the description, port, destination_ips and source_ips properties are not marked as required (thus being optional) although in practice they are always set. This leads to inconsistencies between marshaled schemas and API responses. This PR modifies the schema so that it is consistent with the actual API output.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.35%. Comparing base (7511685) to head (2a90e2d).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   80.35%   80.35%   -0.01%     
==========================================
  Files          32       32              
  Lines        5722     5731       +9     
==========================================
+ Hits         4598     4605       +7     
- Misses        717      718       +1     
- Partials      407      408       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jooola]

What is the rationale behind this change ?

I am not sure if this is valid. As the *_ips fields are only required depending on the direction.

[phm07]

What is the rationale behind this change ?

I am not sure if this is valid. As the *_ips fields are only required depending on the direction.

Yes, they are, but the API returns empty arrays instead of omitting the property, see here:

{
  "id": 1216477,
  "name": "test",
  "labels": {},
  "created": "2024-01-23T08:56:12+00:00",
  "rules": [
    {
      "direction": "in",
      "protocol": "tcp",
      "port": "123",
      "source_ips": [
        "0.0.0.0/0",
        "::/0"
      ],
      "destination_ips": [],
      "description": null
    },
    {
      "direction": "out",
      "protocol": "tcp",
      "port": "123",
      "source_ips": [],
      "destination_ips": [
        "0.0.0.0/0",
        "::/0"
      ],
      "description": null
    }
  ],
  "applied_to": []
}

We should reflect this so that our marshaled schema is consistent with the API responses.