feat: add interfaces for client structs #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
reviewed
Nov 16, 2023
phm07
force-pushed
the
generate-client-interfaces
branch
from
afa87e1
to
d1053f8
Compare
phm07
force-pushed
the
generate-client-interfaces
branch
from
d1053f8
to
1424f76
Compare
apricote
approved these changes
Nov 17, 2023
phm07
pushed a commit
that referenced
this pull request
Dec 12, 2023
🤖 I have created a release *beep* *boop* --- ## [2.5.0](v2.4.0...v2.5.0) (2023-12-12) ### Features * add conversion methods from schema to hcloud objects ([#343](#343)) ([6feda4d](6feda4d)) * add interfaces for client structs ([#342](#342)) ([4f9390f](4f9390f)) * add missing properties ([#349](#349)) ([c8a28d0](c8a28d0)) * **error:** include http response in api errors ([#320](#320)) ([9558239](9558239)) ### Bug Fixes * make schemas consistent with API ([#348](#348)) ([b0d7055](b0d7055)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
phm07
added a commit
to hetznercloud/cli
that referenced
this pull request
Dec 13, 2023
Once hetznercloud/hcloud-go#342 is merged, `hcloud-go` provides its own interfaces for clients. We can thus remove the ones we generated ourselves and use the provided ones instead. Also, the `interfacer` tool can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds auto-generated interfaces for client structs. This allows easier mocking of clients for tests.
The interfaces will have the same name as the corresponding struct, except for beginning with an
I. So for example, the interface forServerClientwould beIServerClient.The SDK itself will not use these new interface types, as most client structs have exported properties and using the interface types would thus be a breaking change.