feat: make ListOpts.Values method public (#285)

jooola · web-flow · commit c82ea5971d94 · 2023-07-11T09:15:46.000+02:00
diff --git a/hcloud/action.go b/hcloud/action.go
@@ -102,7 +102,7 @@ type ActionListOpts struct {
 }
 
 func (l ActionListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	for _, id := range l.ID {
 		vals.Add("id", fmt.Sprintf("%d", id))
 	}
diff --git a/hcloud/certificate.go b/hcloud/certificate.go
@@ -142,7 +142,7 @@ type CertificateListOpts struct {
 }
 
 func (l CertificateListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/client.go b/hcloud/client.go
@@ -445,7 +445,8 @@ type ListOpts struct {
 	LabelSelector string // Label selector for filtering by labels
 }
 
-func (l ListOpts) values() url.Values {
+// Values returns the ListOpts as URL values.
+func (l ListOpts) Values() url.Values {
 	vals := url.Values{}
 	if l.Page > 0 {
 		vals.Add("page", strconv.Itoa(l.Page))
diff --git a/hcloud/datacenter.go b/hcloud/datacenter.go
@@ -76,7 +76,7 @@ type DatacenterListOpts struct {
 }
 
 func (l DatacenterListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/firewall.go b/hcloud/firewall.go
@@ -140,7 +140,7 @@ type FirewallListOpts struct {
 }
 
 func (l FirewallListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/floating_ip.go b/hcloud/floating_ip.go
@@ -141,7 +141,7 @@ type FloatingIPListOpts struct {
 }
 
 func (l FloatingIPListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/image.go b/hcloud/image.go
@@ -163,7 +163,7 @@ type ImageListOpts struct {
 }
 
 func (l ImageListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	for _, typ := range l.Type {
 		vals.Add("type", string(typ))
 	}
diff --git a/hcloud/iso.go b/hcloud/iso.go
@@ -97,7 +97,7 @@ type ISOListOpts struct {
 }
 
 func (l ISOListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/load_balancer.go b/hcloud/load_balancer.go
@@ -287,7 +287,7 @@ type LoadBalancerListOpts struct {
 }
 
 func (l LoadBalancerListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/load_balancer_type.go b/hcloud/load_balancer_type.go
@@ -73,7 +73,7 @@ type LoadBalancerTypeListOpts struct {
 }
 
 func (l LoadBalancerTypeListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/location.go b/hcloud/location.go
@@ -73,7 +73,7 @@ type LocationListOpts struct {
 }
 
 func (l LocationListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/network.go b/hcloud/network.go
@@ -122,7 +122,7 @@ type NetworkListOpts struct {
 }
 
 func (l NetworkListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/placement_group.go b/hcloud/placement_group.go
@@ -84,7 +84,7 @@ type PlacementGroupListOpts struct {
 }
 
 func (l PlacementGroupListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/primary_ip.go b/hcloud/primary_ip.go
@@ -222,7 +222,7 @@ type PrimaryIPListOpts struct {
 }
 
 func (l PrimaryIPListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/server.go b/hcloud/server.go
@@ -241,7 +241,7 @@ type ServerListOpts struct {
 }
 
 func (l ServerListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/server_type.go b/hcloud/server_type.go
@@ -100,7 +100,7 @@ type ServerTypeListOpts struct {
 }
 
 func (l ServerTypeListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/ssh_key.go b/hcloud/ssh_key.go
@@ -85,7 +85,7 @@ type SSHKeyListOpts struct {
 }
 
 func (l SSHKeyListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}
diff --git a/hcloud/volume.go b/hcloud/volume.go
@@ -96,7 +96,7 @@ type VolumeListOpts struct {
 }
 
 func (l VolumeListOpts) values() url.Values {
-	vals := l.ListOpts.values()
+	vals := l.ListOpts.Values()
 	if l.Name != "" {
 		vals.Add("name", l.Name)
 	}

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ type ActionListOpts struct {`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`func (l ActionListOpts) values() url.Values {`
`105`		`- vals := l.ListOpts.values()`
	`105`	`+ vals := l.ListOpts.Values()`
`106`	`106`	`for _, id := range l.ID {`
`107`	`107`	`vals.Add("id", fmt.Sprintf("%d", id))`
`108`	`108`	`}`
Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ type CertificateListOpts struct {`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`func (l CertificateListOpts) values() url.Values {`
`145`		`- vals := l.ListOpts.values()`
	`145`	`+ vals := l.ListOpts.Values()`
`146`	`146`	`if l.Name != "" {`
`147`	`147`	`vals.Add("name", l.Name)`
`148`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -445,7 +445,8 @@ type ListOpts struct {`
`445`	`445`	`LabelSelector string // Label selector for filtering by labels`
`446`	`446`	`}`
`447`	`447`
`448`		`-func (l ListOpts) values() url.Values {`
	`448`	`+// Values returns the ListOpts as URL values.`
	`449`	`+func (l ListOpts) Values() url.Values {`
`449`	`450`	`vals := url.Values{}`
`450`	`451`	`if l.Page > 0 {`
`451`	`452`	`vals.Add("page", strconv.Itoa(l.Page))`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ type DatacenterListOpts struct {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`func (l DatacenterListOpts) values() url.Values {`
`79`		`- vals := l.ListOpts.values()`
	`79`	`+ vals := l.ListOpts.Values()`
`80`	`80`	`if l.Name != "" {`
`81`	`81`	`vals.Add("name", l.Name)`
`82`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ type FirewallListOpts struct {`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`func (l FirewallListOpts) values() url.Values {`
`143`		`- vals := l.ListOpts.values()`
	`143`	`+ vals := l.ListOpts.Values()`
`144`	`144`	`if l.Name != "" {`
`145`	`145`	`vals.Add("name", l.Name)`
`146`	`146`	`}`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ type FloatingIPListOpts struct {`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`func (l FloatingIPListOpts) values() url.Values {`
`144`		`- vals := l.ListOpts.values()`
	`144`	`+ vals := l.ListOpts.Values()`
`145`	`145`	`if l.Name != "" {`
`146`	`146`	`vals.Add("name", l.Name)`
`147`	`147`	`}`
Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ type ImageListOpts struct {`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`func (l ImageListOpts) values() url.Values {`
`166`		`- vals := l.ListOpts.values()`
	`166`	`+ vals := l.ListOpts.Values()`
`167`	`167`	`for _, typ := range l.Type {`
`168`	`168`	`vals.Add("type", string(typ))`
`169`	`169`	`}`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ type ISOListOpts struct {`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`func (l ISOListOpts) values() url.Values {`
`100`		`- vals := l.ListOpts.values()`
	`100`	`+ vals := l.ListOpts.Values()`
`101`	`101`	`if l.Name != "" {`
`102`	`102`	`vals.Add("name", l.Name)`
`103`	`103`	`}`
Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ type LoadBalancerListOpts struct {`
`287`	`287`	`}`
`288`	`288`
`289`	`289`	`func (l LoadBalancerListOpts) values() url.Values {`
`290`		`- vals := l.ListOpts.values()`
	`290`	`+ vals := l.ListOpts.Values()`
`291`	`291`	`if l.Name != "" {`
`292`	`292`	`vals.Add("name", l.Name)`
`293`	`293`	`}`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ type LoadBalancerTypeListOpts struct {`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`func (l LoadBalancerTypeListOpts) values() url.Values {`
`76`		`- vals := l.ListOpts.values()`
	`76`	`+ vals := l.ListOpts.Values()`
`77`	`77`	`if l.Name != "" {`
`78`	`78`	`vals.Add("name", l.Name)`
`79`	`79`	`}`