feat: include action ID in action error string (#539)

This allows us to easily debug the failed action from user provided
logs.

Author: jooola

hcloud/action.go

@@ -64,6 +64,11 @@ func (e ActionError) Action() *Action {
 }
 
 func (e ActionError) Error() string {
+	action := e.Action()
+	if action != nil {
+		// For easier debugging, the error string contains the Action ID.
+		return fmt.Sprintf("%s (%s, %d)", e.Message, e.Code, action.ID)
+	}
 	return fmt.Sprintf("%s (%s)", e.Message, e.Code)
 }
 

hcloud/action_test.go

@@ -7,9 +7,22 @@ import (
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/assert"
+
 	"github.com/hetznercloud/hcloud-go/v2/hcloud/schema"
 )
 
+func TestActionError(t *testing.T) {
+	assert.Equal(t,
+		"action failed (failed)",
+		ActionError{Code: "failed", Message: "action failed"}.Error(),
+	)
+	assert.Equal(t,
+		"action failed (failed, 12345)",
+		ActionError{Code: "failed", Message: "action failed", action: &Action{ID: 12345}}.Error(),
+	)
+}
+
 func TestActionClientGetByID(t *testing.T) {
 	env := newTestEnv()
 	defer env.Teardown()