Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(primary-ip): change protection commands do not allow protection levels #851

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Aug 26, 2024

Since the protections level support for Primary IPs was added later, they are optional so that the command is backwards compatible. This meant that the usage validation was not working properly. This PR fixes this and adds tests.

@phm07 phm07 added the bug label Aug 26, 2024
@phm07 phm07 self-assigned this Aug 26, 2024
@phm07 phm07 requested a review from a team as a code owner August 26, 2024 14:22
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.50%. Comparing base (2cf34e9) to head (f402a87).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #851   +/-   ##
=======================================
  Coverage   61.49%   61.50%           
=======================================
  Files         238      238           
  Lines        8502     8504    +2     
=======================================
+ Hits         5228     5230    +2     
  Misses       2568     2568           
  Partials      706      706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 merged commit 697a87a into main Aug 30, 2024
5 checks passed
@phm07 phm07 deleted the fix-primary-ip-enable-protection branch August 30, 2024 10:42
phm07 pushed a commit that referenced this pull request Aug 30, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.47.0](v1.46.0...v1.47.0)
(2024-08-30)


### Features

* allow deleting rDNS entries
([#839](#839))
([129f51d](129f51d)),
closes [#814](#814)
* **certificate:** allow retrying managed certificate issuance
([#847](#847))
([0223f7d](0223f7d))
* improve datacenter describe server types readability
([#854](#854))
([fc0002c](fc0002c)),
closes [#852](#852)


### Bug Fixes

* `quiet` option sometimes only working as a flag
([#846](#846))
([f7c9ac6](f7c9ac6))
* **image:** only accept numerical ids for update, delete, label
([#844](#844))
([7355571](7355571))
* **load-balancer:** show message if none of --server, --label-selector
or --ip is set ([#849](#849))
([2df45e0](2df45e0))
* **primary-ip:** change protection commands do not allow protection
levels ([#851](#851))
([697a87a](697a87a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants