Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quiet option sometimes only working as a flag #846

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix: quiet option sometimes only working as a flag #846

merged 1 commit into from
Aug 19, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Aug 19, 2024

In some places, the old Flags().GetBool() was used instead of actually using the option. That causes the quiet option to be ignored in these places if it is set via the config file or environment variables.

@phm07 phm07 added the bug label Aug 19, 2024
@phm07 phm07 self-assigned this Aug 19, 2024
@phm07 phm07 requested a review from a team as a code owner August 19, 2024 09:05
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.46%. Comparing base (140c11e) to head (7b14dbe).
Report is 3 commits behind head on main.

Files Patch % Lines
internal/state/actions.go 0.00% 4 Missing ⚠️
internal/cmd/base/describe.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
- Coverage   61.49%   61.46%   -0.04%     
==========================================
  Files         237      237              
  Lines        8480     8485       +5     
==========================================
  Hits         5215     5215              
- Misses       2560     2564       +4     
- Partials      705      706       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 merged commit f7c9ac6 into main Aug 19, 2024
5 checks passed
@phm07 phm07 deleted the fix-quiet branch August 19, 2024 09:22
phm07 pushed a commit that referenced this pull request Aug 30, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.47.0](v1.46.0...v1.47.0)
(2024-08-30)


### Features

* allow deleting rDNS entries
([#839](#839))
([129f51d](129f51d)),
closes [#814](#814)
* **certificate:** allow retrying managed certificate issuance
([#847](#847))
([0223f7d](0223f7d))
* improve datacenter describe server types readability
([#854](#854))
([fc0002c](fc0002c)),
closes [#852](#852)


### Bug Fixes

* `quiet` option sometimes only working as a flag
([#846](#846))
([f7c9ac6](f7c9ac6))
* **image:** only accept numerical ids for update, delete, label
([#844](#844))
([7355571](7355571))
* **load-balancer:** show message if none of --server, --label-selector
or --ip is set ([#849](#849))
([2df45e0](2df45e0))
* **primary-ip:** change protection commands do not allow protection
levels ([#851](#851))
([697a87a](697a87a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants