From 04446c3ca0211e805d9c1b01097180462c31e4c1 Mon Sep 17 00:00:00 2001 From: hasegawa-101 Date: Wed, 19 Nov 2025 23:54:01 +0900 Subject: [PATCH 1/5] fix(skeleton): restore shimmer animation for background transition --- packages/core/theme/src/components/skeleton.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/core/theme/src/components/skeleton.ts b/packages/core/theme/src/components/skeleton.ts index af7c203c82..1e157109fb 100644 --- a/packages/core/theme/src/components/skeleton.ts +++ b/packages/core/theme/src/components/skeleton.ts @@ -25,7 +25,6 @@ const skeleton = tv({ "before:absolute", "before:inset-0", "before:-translate-x-full", - "before:animate-shimmer", "before:border-t", "before:border-content4/30", "before:bg-gradient-to-r", @@ -56,7 +55,7 @@ const skeleton = tv({ content: "transition-none", }, false: { - base: "transition-background !duration-300", + base: "before:animate-shimmer transition-background !duration-300", content: "transition-opacity motion-reduce:transition-none !duration-300", }, }, From 5640136b139ec365e2b3fd76949c6ed2693fa372 Mon Sep 17 00:00:00 2001 From: hasegawa-101 Date: Wed, 19 Nov 2025 23:59:56 +0900 Subject: [PATCH 2/5] chore: changeset --- .changeset/tiny-hairs-collect.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tiny-hairs-collect.md diff --git a/.changeset/tiny-hairs-collect.md b/.changeset/tiny-hairs-collect.md new file mode 100644 index 0000000000..c75abff744 --- /dev/null +++ b/.changeset/tiny-hairs-collect.md @@ -0,0 +1,5 @@ +--- +"@heroui/theme": patch +--- + +fixed skeleton shimmer animation not respecting disableAnimation prop (#5915) From 8338f7eed258258a85c5cea78795d24c69542670 Mon Sep 17 00:00:00 2001 From: WK Wong Date: Fri, 21 Nov 2025 10:51:25 +0800 Subject: [PATCH 3/5] chore(skeleton): bump theme peer dep --- packages/components/skeleton/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/skeleton/package.json b/packages/components/skeleton/package.json index 1d1168015d..7b44bf89a3 100644 --- a/packages/components/skeleton/package.json +++ b/packages/components/skeleton/package.json @@ -36,7 +36,7 @@ "peerDependencies": { "react": ">=18 || >=19.0.0-rc.0", "react-dom": ">=18 || >=19.0.0-rc.0", - "@heroui/theme": ">=2.4.17", + "@heroui/theme": ">=2.4.23", "@heroui/system": ">=2.4.18" }, "dependencies": { From 9007ab5690e7f2f8c1690e0d71e3b361712343aa Mon Sep 17 00:00:00 2001 From: WK Wong Date: Fri, 21 Nov 2025 10:53:48 +0800 Subject: [PATCH 4/5] chore(skeleton): pass args to first skeleton --- packages/components/skeleton/stories/skeleton.stories.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/skeleton/stories/skeleton.stories.tsx b/packages/components/skeleton/stories/skeleton.stories.tsx index 4853de7ce2..67f6ebc566 100644 --- a/packages/components/skeleton/stories/skeleton.stories.tsx +++ b/packages/components/skeleton/stories/skeleton.stories.tsx @@ -56,7 +56,7 @@ const DefaultTemplate = (args: SkeletonProps) => ( const StandaloneTemplate = (args: SkeletonProps) => (
- +
From b363806f5f8f53a368b739beab979acefa633142 Mon Sep 17 00:00:00 2001 From: WK Wong Date: Fri, 21 Nov 2025 10:54:39 +0800 Subject: [PATCH 5/5] chore(changeset): bump skeleton --- .changeset/tiny-hairs-collect.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.changeset/tiny-hairs-collect.md b/.changeset/tiny-hairs-collect.md index c75abff744..3c25f01363 100644 --- a/.changeset/tiny-hairs-collect.md +++ b/.changeset/tiny-hairs-collect.md @@ -1,5 +1,6 @@ --- "@heroui/theme": patch +"@heroui/skeleton": patch --- fixed skeleton shimmer animation not respecting disableAnimation prop (#5915)