From 3a2ba4cf8e9d4c38a71d465e93dcc203d27732cc Mon Sep 17 00:00:00 2001 From: WK Wong Date: Sun, 8 Jun 2025 11:35:38 +0800 Subject: [PATCH 1/2] refactor(number-input): avoid non number type passing to number input --- packages/components/number-input/src/number-input.tsx | 4 +++- packages/components/number-input/src/use-number-input.ts | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/components/number-input/src/number-input.tsx b/packages/components/number-input/src/number-input.tsx index 1a596d992b..c71fc45fc6 100644 --- a/packages/components/number-input/src/number-input.tsx +++ b/packages/components/number-input/src/number-input.tsx @@ -5,7 +5,9 @@ import {forwardRef} from "@heroui/system"; import {UseNumberInputProps, useNumberInput} from "./use-number-input"; import NumberInputStepper from "./number-input-stepper"; -export interface NumberInputProps extends UseNumberInputProps {} +export interface NumberInputProps extends Omit { + type?: "number"; +} const NumberInput = forwardRef<"input", NumberInputProps>((props, ref) => { const { diff --git a/packages/components/number-input/src/use-number-input.ts b/packages/components/number-input/src/use-number-input.ts index 175e22481b..44a93d89f8 100644 --- a/packages/components/number-input/src/use-number-input.ts +++ b/packages/components/number-input/src/use-number-input.ts @@ -99,6 +99,7 @@ export function useNumberInput(originalProps: UseNumberInputProps) { const { ref, as, + type, label, baseRef, wrapperRef, @@ -539,6 +540,7 @@ export function useNumberInput(originalProps: UseNumberInputProps) { return { Component, classNames, + type, domRef, label, description, From c6efb644d65820fb7025e47bc8b0c1307411ae1d Mon Sep 17 00:00:00 2001 From: WK Wong Date: Sun, 8 Jun 2025 11:40:28 +0800 Subject: [PATCH 2/2] chore(changeset): add changeset --- .changeset/stupid-shrimps-divide.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/stupid-shrimps-divide.md diff --git a/.changeset/stupid-shrimps-divide.md b/.changeset/stupid-shrimps-divide.md new file mode 100644 index 0000000000..e7dbd7e6bf --- /dev/null +++ b/.changeset/stupid-shrimps-divide.md @@ -0,0 +1,5 @@ +--- +"@heroui/number-input": patch +--- + +avoid non number type passing to NumberInput