From 921a4cd8c06f74030365c1ec98eb4bddf9dd4e57 Mon Sep 17 00:00:00 2001 From: Poli Sour Date: Wed, 20 Mar 2024 15:17:32 +0800 Subject: [PATCH] fix(select): positioning the label if a description is used --- .changeset/giant-carrots-reply.md | 5 +++++ packages/components/select/src/select.tsx | 6 +++--- packages/components/select/src/use-select.ts | 2 ++ 3 files changed, 10 insertions(+), 3 deletions(-) create mode 100644 .changeset/giant-carrots-reply.md diff --git a/.changeset/giant-carrots-reply.md b/.changeset/giant-carrots-reply.md new file mode 100644 index 0000000000..03c45a80bb --- /dev/null +++ b/.changeset/giant-carrots-reply.md @@ -0,0 +1,5 @@ +--- +"@nextui-org/select": patch +--- + +Fixed the bug of positioning the label in the `Select` component if the description field was used diff --git a/packages/components/select/src/select.tsx b/packages/components/select/src/select.tsx index c14bc07f85..c2db8af880 100644 --- a/packages/components/select/src/select.tsx +++ b/packages/components/select/src/select.tsx @@ -28,7 +28,7 @@ function Select(props: Props, ref: ForwardedRef(props: Props, ref: ForwardedRef - {shouldLabelBeOutside ? labelContent : null} + {isOutsideLeft ? labelContent : null}
- {!shouldLabelBeOutside ? labelContent : null} + {!isOutsideLeft ? labelContent : null}
{startContent} diff --git a/packages/components/select/src/use-select.ts b/packages/components/select/src/use-select.ts index 93fd406494..dd86f2e167 100644 --- a/packages/components/select/src/use-select.ts +++ b/packages/components/select/src/use-select.ts @@ -262,6 +262,7 @@ export function useSelect(originalProps: UseSelectProps) { labelPlacement === "outside-left" || (labelPlacement === "outside" && (hasPlaceholder || !!originalProps.isMultiline)); const shouldLabelBeInside = labelPlacement === "inside"; + const isOutsideLeft = labelPlacement === "outside-left"; const isFilled = state.isOpen || @@ -585,6 +586,7 @@ export function useSelect(originalProps: UseSelectProps) { renderValue, selectionMode, disableAnimation, + isOutsideLeft, shouldLabelBeOutside, shouldLabelBeInside, getBaseProps,