Skip to content

fix(theme): chip with dot variant is not properly padded when having …#2387

Merged
jrgarciadev merged 1 commit into
heroui-inc:mainfrom
kuri-sun:fix/theme/chip-with-dot-variant-is-not-properly-padded-when-having
Mar 3, 2024
Merged

fix(theme): chip with dot variant is not properly padded when having …#2387
jrgarciadev merged 1 commit into
heroui-inc:mainfrom
kuri-sun:fix/theme/chip-with-dot-variant-is-not-properly-padded-when-having

Conversation

@kuri-sun
Copy link
Copy Markdown

…a 1-char text

Closes #2383

📝 Description

Chip is not properly padded when using the "dot" variant and using a 1-char string as children.

⛳️ Current behavior (updates)

Here is the previous style for the Chip component.

prev

🚀 New behavior

Here is the updated style for the Chip component.

curr2

curr

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 20, 2024

🦋 Changeset detected

Latest commit: 436fa97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/theme Major
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 4:22am

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 20, 2024

@kuri-sun is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @kuri-sun

@jrgarciadev jrgarciadev merged commit 141887d into heroui-inc:main Mar 3, 2024
@kuri-sun kuri-sun deleted the fix/theme/chip-with-dot-variant-is-not-properly-padded-when-having branch March 3, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Chip] - Chip with dot variant is not properly padded when having a 1-char text

3 participants