Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/feature: Rate-throttling logic is global and not per-token #112

Open
schneems opened this issue Oct 6, 2020 · 1 comment
Open

Bug/feature: Rate-throttling logic is global and not per-token #112

schneems opened this issue Oct 6, 2020 · 1 comment

Comments

@schneems
Copy link
Contributor

schneems commented Oct 6, 2020

When I added the rate-throttle logic I did so on the assumption that the process would be making requests on behalf of a single token. I think this is still the most common case, but I didn't account for the scenario where one process might make many requests using many different tokens (think if you've written some kind of a proxy service and operates on each individual token).

The way to move forward is to make the RateThrottleClient instance local to each instance of PlatformAPI. This will require work in Heroics since that's what we hook into to provide this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@schneems and others