Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies from the "Update builder" job #117

Open
edmorley opened this issue Aug 16, 2023 · 0 comments
Open

Remove unnecessary dependencies from the "Update builder" job #117

edmorley opened this issue Aug 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@edmorley
Copy link
Member

edmorley commented Aug 16, 2023

Currently the "Update the builder" job runs at the very end, since it's declared as having a dependency on all of the other jobs:

flowchart LR
    A[Compile buildpacks] --> B[Publish to Docker Hub]
    B --> C[Publish to CNB registry]
    A --> D[Create GitHub release]
    C & D --> E[Update builder]
Loading

However, opening the builder PR only actually needs the "Publish to Docker Hub" step to have been completed. ie:

flowchart LR
    A[Compile buildpacks] --> B[Publish to Docker Hub]
    B --> C[Publish to CNB registry]
    A --> D[Create GitHub release]
    B --> E[Update builder]
Loading

By removing these unnecessary dependencies from the workflow definition, we:

  1. Ensure that we can still publish builder updates if the CNB registry is having downtime (xref https://salesforce.quip.com/QRwnAaGborAF#temp:C:RCc6106ab8f1a3e4f37968a5b44a)
  2. Speed up the end to end time of publishing a CNB, since more of the jobs can now run in parallel

However, we might want to wait to do this until we've done #113, since currently the only signal buildpack maintainers have for failed jobs is that the builder update PR never gets opened - so we want to make sure there is still a way to see that eg the CNB registry job has failed.

GUS-W-13956414.

@edmorley edmorley added the enhancement New feature or request label Aug 16, 2023
@edmorley edmorley changed the title Remove the "Update builder" job's dependency on publishing to the CNB registry Remove unnecessary dependencies from the "Update builder" job Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant