fix: use parse-json (#26)

shows better errors when invalid

Author: jdx

package.json

@@ -9,6 +9,7 @@
     "debug": "^3.1.0",
     "is-retry-allowed": "^1.1.0",
     "is-stream": "^1.1.0",
+    "parse-json": "^4.0.0",
     "tunnel-agent": "^0.6.0"
   },
   "devDependencies": {
@@ -18,6 +19,7 @@
     "@types/jest": "^23.3.1",
     "@types/nock": "^9.3.0",
     "@types/node": "^10.9.3",
+    "@types/parse-json": "^4.0.0",
     "jest": "^23.5.0",
     "nock": "^9.6.1",
     "ts-jest": "^23.1.4",

src/http.ts

@@ -1,4 +1,5 @@
 import http = require('http')
+import JSONParse = require('parse-json')
 import * as uri from 'url'
 import * as util from 'util'
 
@@ -389,7 +390,7 @@ export class HTTP<T> {
     this.body = await concat(this.response) as T
     let type = this.response.headers['content-type'] ? deps.contentType.parse(this.response).type : ''
     let json = type.startsWith('application/json') || type.startsWith('application/vnd.api+json')
-    if (json) this.body = JSON.parse(this.body as any as string)
+    if (json) this.body = JSONParse(this.body as any as string)
   }
 
   private _parseBody(body: object) {

yarn.lock

@@ -51,6 +51,11 @@
   version "10.9.3"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-10.9.3.tgz#85f288502503ade0b3bfc049fe1777b05d0327d5"
 
+"@types/parse-json@^4.0.0":
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/@types/parse-json/-/parse-json-4.0.0.tgz#2f8bb441434d163b35fb8ffdccd7138927ffb8c0"
+  integrity sha512-//oorEZjL6sbPcKUaCdIGlIUeH26mgzimjBB77G6XRgnDl/L5wOnpyBGRe/Mmf5CVW3PwEBE1NjiMZ/ssFh4wA==
+
 abab@^1.0.4:
   version "1.0.4"
   resolved "https://registry.yarnpkg.com/abab/-/abab-1.0.4.tgz#5faad9c2c07f60dd76770f71cf025b62a63cfd4e"
@@ -777,7 +782,7 @@ ecc-jsbn@~0.1.1:
     jsbn "~0.1.0"
     safer-buffer "^2.1.0"
 
-error-ex@^1.2.0:
+error-ex@^1.2.0, error-ex@^1.3.1:
   version "1.3.2"
   resolved "https://registry.yarnpkg.com/error-ex/-/error-ex-1.3.2.tgz#b4ac40648107fdcdcfae242f428bea8a14d4f1bf"
   dependencies:
@@ -1875,6 +1880,11 @@ jsesc@^1.3.0:
   version "1.3.0"
   resolved "https://registry.yarnpkg.com/jsesc/-/jsesc-1.3.0.tgz#46c3fec8c1892b12b0833db9bc7622176dbab34b"
 
+json-parse-better-errors@^1.0.1:
+  version "1.0.2"
+  resolved "https://registry.yarnpkg.com/json-parse-better-errors/-/json-parse-better-errors-1.0.2.tgz#bb867cfb3450e69107c131d1c514bab3dc8bcaa9"
+  integrity sha512-mrqyZKfX5EhL7hvqcV6WG1yYjnjeuYDzDhhcAAUrq8Po85NBQBJP+ZDUT75qZQ98IkUoBqdkExkukOU7Ts2wrw==
+
 json-schema-traverse@^0.3.0:
   version "0.3.1"
   resolved "https://registry.yarnpkg.com/json-schema-traverse/-/json-schema-traverse-0.3.1.tgz#349a6d44c53a51de89b40805c5d5e59b417d3340"
@@ -2389,6 +2399,14 @@ parse-json@^2.2.0:
   dependencies:
     error-ex "^1.2.0"
 
+parse-json@^4.0.0:
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/parse-json/-/parse-json-4.0.0.tgz#be35f5425be1f7f6c747184f98a788cb99477ee0"
+  integrity sha1-vjX1Qlvh9/bHRxhPmKeIy5lHfuA=
+  dependencies:
+    error-ex "^1.3.1"
+    json-parse-better-errors "^1.0.1"
+
 [email protected]:
   version "4.0.0"
   resolved "https://registry.yarnpkg.com/parse5/-/parse5-4.0.0.tgz#6d78656e3da8d78b4ec0b906f7c08ef1dfe3f608"