Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move repo:purge_cache to heroku-builds #52

Closed
edmorley opened this issue Jul 21, 2017 · 1 comment
Closed

Move repo:purge_cache to heroku-builds #52

edmorley opened this issue Jul 21, 2017 · 1 comment

Comments

@edmorley
Copy link
Member

Hi!

As discussed in heroku/cli#509 and heroku/heroku-repo#69, it seems like the heroku-repo plugin isn't the best fit for the cache related command repo:purge_cache, particularly now that the caches are no longer tied to the git repo.

As such, heroku-builds seems like a good home, perhaps in the form of builds:purge-cache or heroku builds:cache:purge.

The existing code is here:
https://github.com/heroku/heroku-repo/blob/3e7167d79ca06f8be9cc4b084f7ca03d5adaee46/commands/purge_cache.js
https://github.com/heroku/heroku-repo/blob/3e7167d79ca06f8be9cc4b084f7ca03d5adaee46/lib/repo.js#L15-L16

Note there are some open tickets against this feature:

Plus heroku/cli#509 (comment) identified the following cleanups:

  • rename command to something better
  • show example of usage including output
  • description is unclear and has improper grammar
  • description verb should be 'delete' not 'deletes'

After this move, I'd also like to add a command to download the cache file for debugging (similar to the slugs:download command from heroku-slugs) - so worth bearing in mind for the naming.

I also wonder whether the slugs:* commands from heroku-slugs should be moved under the "builds" topic too, once builds covers {builds, cache, ...}?

@dmathieu
Copy link
Contributor

The old command is now deprecated, and will be removed someday in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants