Basic Auth Configuration #45

randallagordon · 2016-08-29T20:15:43Z

What's this PR do?

Adds the ability to configure Basic Authentication.

Will generate .htpasswd if environment variables BASIC_AUTH_USERNAME and BASIC_AUTH_PASSWORD are present; otherwise use an .htpasswd file present in the app directory.

To configure, in static.json:

{
  "basic_auth": true
}

Background

Closes #43, where Basic Auth support was requested by @josephabrahams.

@donbobka

Improvements and fixed tests. Thank you, @donbobka!

randallagordon · 2016-09-22T17:27:39Z

Thank you @donbobka for fixing the tests and doing some general improvements!

randallagordon · 2016-11-10T18:16:59Z

Just wanted to follow up and check if there's anything else blocking this from being merged?

paulmsmith · 2016-11-28T20:22:23Z

I can't get this to work. I've forked it and used it. I'm presented with basic-auth username and password but it doesn't seem to recognise the username and password.

I assumed if I set config vars within heroku for BASIC_AUTH_USERNAME and BASIC_AUTH_PASSWORD that was all I'd need to do.

In the logs I see: user "dev-dwp-design": password mismatch

donbobka · 2016-11-28T20:33:16Z

@paulmsmith, BASIC_AUTH_PASSWORD must be a hash of your password. Use command openssl passwd -apr1 to hash your password

paulmsmith · 2016-11-28T20:35:46Z

@donbobka Oh of course! Thanks for the mighty swift reply!

paulmsmith · 2016-11-28T20:40:08Z

@donbobka Actually, still not working. Where am I supposed to stored the hashed password? In the config vars? (Long day! :))

Edit. I think I was being dumb... will post back......

paulmsmith · 2016-11-28T20:43:14Z

@donbobka I was being dumb. I paste the username and hashed that. Thank you for the work. Hopefully will make it in to the final repo.

ghost · 2016-12-08T01:49:29Z

I've been using this for almost a month now in our 2 pre-production environments with great success.

https://github.com/Aculeus/create-react-app-buildpack/blob/master/.buildpacks

dcarral · 2017-01-11T14:49:44Z

Hi @hone, what do you think about these changes? ;)

ianstormtaylor · 2017-02-16T22:58:40Z

Hey @randallagordon I'm trying to use this via your branch, but for some reason even when adding BASIC_AUTH_PASSWORD and BASIC_AUTH_USERNAME, no .htpasswd file is created on new deploys. And even if I manually add the .htpasswd file myself, it's still not picked up.

I have a feeling the buildpack isn't actually taking effect, even though I've run:

heroku buildpacks:set https://github.com/doinginc/heroku-buildpack-static.git#basic-auth

(I've also tried...)

heroku buildpacks:set https://github.com/doinginc/heroku-buildpack-static#basic-auth

Anyone know why?

randallagordon · 2017-02-23T00:49:13Z

@ianstormtaylor it should work with or without the .git in the URL—I'm using it on two Heroku apps currently and inadvertently used the different variations on each! If you're using multiple buildpacks, it needs to be the last buildpack to execute. That's the only thing I can think of to check at the moment.

bartocc · 2017-03-06T11:57:59Z

Is there anything holding this PR to be merged ?

Thx

wolovim · 2017-05-08T16:37:24Z

Happy Monday! I'd love to see this feature. Could today be the day? /bump

viperfx07 · 2017-05-12T01:10:40Z

TGIF! I'd love to see this feature as well. Could today be the day? /bumpagain

josercruz01 · 2017-05-30T18:40:48Z

Ping! Any plans on when this will be merged? We could use it to add basic auth to our review apps. /bumpagain

jeremieca · 2017-06-08T16:07:56Z

Ping

moha297 · 2017-06-18T20:41:10Z

Why are we not merging this PR?

viperfx07 · 2017-07-28T05:51:23Z

I merged it manually on my repo, https://github.com/viperfx07/heroku-buildpack-static, just in case anyone needs it.

Cheers

gabrielperales · 2017-12-04T21:15:30Z

Hi @viperfx07, I'm using your fork, and I'm having an issue. I'm getting a 401 error when I request my backend through a proxy. Is anyone having the same issue? Or anyone knows how I can fix it?

coffenbacher · 2018-03-04T18:42:40Z

Why has this PR been open since 2016 with no justification for not being merged? Can't be inspiring for contributors... 😬

cancan101 · 2018-07-30T21:33:38Z

Ping on this? Would be great to have this!

BevanR · 2018-08-21T03:55:39Z

@hone This is well tested by the community. It would be great to get it in.

patcon · 2018-09-05T19:34:10Z

Related: #111

ludwiktrammer · 2018-12-27T21:57:09Z

@Dhaulagiri @hone Are there any updates on this?

felipemalinoski · 2019-03-19T14:41:14Z

Please move this forward, there're so many forks in this repo because of this small feature!

Listen to your users

/cc @Dhaulagiri @hone

bartocc · 2019-04-04T08:41:20Z

thx @Dhaulagiri 🎉

Because heroku/heroku-buildpack-static#45 looks for `/app/.htpasswd` when: - `"basic_auth": true` (`static.json`), and - `BASIC_AUTH_USERNAME` and `BASIC_AUTH_PASSWORD` are not set

cancan101 · 2019-04-29T21:05:19Z

Is there any way to enable / disable basic auth based on an env var?

patcon · 2019-04-29T21:24:22Z

@cancan101 I'd recommend starting a new issue for this support/feature request <3

* upstream/master: Basic Auth Configuration (heroku#45) # Conflicts: # scripts/config/templates/nginx.conf.erb

* Basic Basic Auth * Allow username and password to be passed in via env vars * Add test spec for basic auth returning 401 * Update README with Basic Auth config info * Add .htpasswd to test fixture * Set env vars in test * Request the file that actually exists, maybe? * Is context the key? * Perhaps app.run needs to come to the party too? * Move `auth_basic` from `location` to `server` * Set `basic_auth` as true if env `basic_auth_username` exists * Fix htpasswd generation when basic_auth is false * Append env password instead truncating * Fix typo * Fix config example in README

randallagordon and others added 15 commits August 22, 2016 22:38

Basic Basic Auth

9c756e4

Allow username and password to be passed in via env vars

555b819

Add test spec for basic auth returning 401

f3b3534

Update README with Basic Auth config info

bd110a7

Add .htpasswd to test fixture

2e751f9

Set env vars in test

01d5ae7

Request the file that actually exists, maybe?

307f375

Is context the key?

11396f2

Perhaps app.run needs to come to the party too?

9390f6b

Move auth_basic from location to server

5d07228

Set basic_auth as true if env basic_auth_username exists

61f33c4

Fix htpasswd generation when basic_auth is false

4902d04

Append env password instead truncating

0e96a8f

Fix typo

2389b9e

Merge pull request #1 from donbobka/basic-auth

dc76099

Improvements and fixed tests. Thank you, @donbobka!

Fix config example in README

6c2b6f8

bartocc mentioned this pull request Mar 6, 2017

Support for HTTP basic auth heroku/heroku-buildpack-emberjs#25

Closed

Merge branch 'master' into basic-auth

e94c198

ptrikutam mentioned this pull request Nov 1, 2017

Basic Auth Configuration (copy) graybike/heroku-buildpack-static#1

Merged

mkornblum mentioned this pull request Mar 16, 2018

Basic auth substantial/heroku-buildpack-static#1

Merged

shafy mentioned this pull request Mar 22, 2018

Add Basic Auth from Static Buildpack mars/create-react-app-buildpack#93

Closed

EranSch mentioned this pull request Jun 4, 2018

Merge PR from upstream repo (Basic HTTP Auth) 352Media/heroku-buildpack-static#1

Merged

mars mentioned this pull request Aug 12, 2018

Add basic auth mars/create-react-app-buildpack#114

Closed

biw mentioned this pull request Nov 26, 2018

Add Basic Auth biw/heroku-buildpack-static#1

Merged

nicolov added a commit to nicolov/heroku-buildpack-static that referenced this pull request Feb 18, 2019

apply upstream heroku#45 for basic auth

15807c6

felipemalinoski mentioned this pull request Feb 28, 2019

Basic auth cobalthq/heroku-buildpack-static#1

Merged

Dhaulagiri merged commit bde9522 into heroku:master Apr 3, 2019

tangrufus mentioned this pull request Apr 4, 2019

Upload .htpasswd hone/heroku-cli-static#10

Open

cancan101 mentioned this pull request Apr 29, 2019

Ability to enable / disable basic auth using env vars #133

Closed

wgrrrr added a commit to urllo/heroku-buildpack-static that referenced this pull request May 13, 2019

Merge remote-tracking branch 'upstream/master'

7a929a1

* upstream/master: Basic Auth Configuration (heroku#45) # Conflicts: # scripts/config/templates/nginx.conf.erb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic Auth Configuration #45

Basic Auth Configuration #45

randallagordon commented Aug 29, 2016 •

edited

Loading

randallagordon commented Sep 22, 2016

randallagordon commented Nov 10, 2016

paulmsmith commented Nov 28, 2016 •

edited

Loading

donbobka commented Nov 28, 2016

paulmsmith commented Nov 28, 2016

paulmsmith commented Nov 28, 2016 •

edited

Loading

paulmsmith commented Nov 28, 2016

ghost commented Dec 8, 2016

dcarral commented Jan 11, 2017

ianstormtaylor commented Feb 16, 2017

randallagordon commented Feb 23, 2017

bartocc commented Mar 6, 2017

wolovim commented May 8, 2017 •

edited

Loading

viperfx07 commented May 12, 2017

josercruz01 commented May 30, 2017

jeremieca commented Jun 8, 2017

moha297 commented Jun 18, 2017

viperfx07 commented Jul 28, 2017

gabrielperales commented Dec 4, 2017 •

edited

Loading

coffenbacher commented Mar 4, 2018

cancan101 commented Jul 30, 2018

BevanR commented Aug 21, 2018

patcon commented Sep 5, 2018

ludwiktrammer commented Dec 27, 2018

felipemalinoski commented Mar 19, 2019

bartocc commented Apr 4, 2019

cancan101 commented Apr 29, 2019

patcon commented Apr 29, 2019

Basic Auth Configuration #45

Basic Auth Configuration #45

Conversation

randallagordon commented Aug 29, 2016 • edited Loading

What's this PR do?

Background

randallagordon commented Sep 22, 2016

randallagordon commented Nov 10, 2016

paulmsmith commented Nov 28, 2016 • edited Loading

donbobka commented Nov 28, 2016

paulmsmith commented Nov 28, 2016

paulmsmith commented Nov 28, 2016 • edited Loading

paulmsmith commented Nov 28, 2016

ghost commented Dec 8, 2016

dcarral commented Jan 11, 2017

ianstormtaylor commented Feb 16, 2017

randallagordon commented Feb 23, 2017

bartocc commented Mar 6, 2017

wolovim commented May 8, 2017 • edited Loading

viperfx07 commented May 12, 2017

josercruz01 commented May 30, 2017

jeremieca commented Jun 8, 2017

moha297 commented Jun 18, 2017

viperfx07 commented Jul 28, 2017

gabrielperales commented Dec 4, 2017 • edited Loading

coffenbacher commented Mar 4, 2018

cancan101 commented Jul 30, 2018

BevanR commented Aug 21, 2018

patcon commented Sep 5, 2018

ludwiktrammer commented Dec 27, 2018

felipemalinoski commented Mar 19, 2019

bartocc commented Apr 4, 2019

cancan101 commented Apr 29, 2019

patcon commented Apr 29, 2019

randallagordon commented Aug 29, 2016 •

edited

Loading

paulmsmith commented Nov 28, 2016 •

edited

Loading

paulmsmith commented Nov 28, 2016 •

edited

Loading

wolovim commented May 8, 2017 •

edited

Loading

gabrielperales commented Dec 4, 2017 •

edited

Loading