Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Buildkits (codon-buildpacks) copy of the published buildpack is out of date #187

Closed
edmorley opened this issue Nov 22, 2020 · 2 comments
Closed
Assignees

Comments

@edmorley
Copy link
Member

The Buildkits service was replaced by the Buildpack Registry, however there are still some buildpack consumers using the legacy buildkit URLs (that use the codon-buildpacks S3 bucket) instead of the buildpack registry URLs.

Currently the static buildpack isn't on the list of buildpacks synced from the new bucket back to the old, meaning the copy of the buildpack in the old bucket is out of date, and doesn't have the fix for #182 amongst other things.

$ curl -IsSf https://codon-buildpacks.s3.amazonaws.com/buildpacks/heroku/static.tgz | rg '(Last-Modified|ETag)'
Last-Modified: Wed, 14 Jun 2017 21:49:52 GMT
ETag: "7932356db2be01178a3c931e39c115ee"

$ curl -IsSf https://buildpack-registry.s3.amazonaws.com/buildpacks/heroku-community/static.tgz | rg '(Last-Modified|ETag)'
Last-Modified: Wed, 11 Nov 2020 10:35:03 GMT
ETag: "5668d98bb5ee7fa36f776d773b537a4a"

This is causing eg:
heroku/heroku-buildpack-emberjs/issues/65

Whilst long term we would like to remove the last usages of the old bucket, for now we should add this buildpack to the sync list.

Refs W-8480774.

@edmorley edmorley self-assigned this Nov 22, 2020
@edmorley
Copy link
Member Author

edmorley commented Nov 22, 2020

Looking at the published buildkits archive (and diffing against the buildpack registry version), I see the last change that is included in the former is that from #78.

As such the diff between the two is:
995b07c...v5

@edmorley edmorley changed the title Buildkits copy of the published buildpack is out of date Buildkits (codon-buildpacks) copy of the published buildpack is out of date Nov 22, 2020
@edmorley
Copy link
Member Author

I've appended the static buildpack's mapping to buildkit's BUILDPACKS_TO_SYNC.

The buildpack has now been synced:

$ curl -IsSf https://codon-buildpacks.s3.amazonaws.com/buildpacks/heroku/static.tgz | rg '(Last-Modified|ETag)'
Last-Modified: Sun, 22 Nov 2020 17:20:16 GMT
ETag: "5668d98bb5ee7fa36f776d773b537a4a"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant